[Offline Pages] Moves Coordinator to using MarkAttemptStarted/MarkAttemptCompleted API.

components/offline_pages/background/offliner.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 #define COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_
 
 #include "base/callback.h"
 
 namespace offline_pages {
@@ skipping 21 matching lines @@
     // Prerendering failed to load page.
     PRERENDERING_FAILED = 5,
     // Failed to save loaded page.
     SAVE_FAILED = 6,
     // Foreground transition canceled request.
     FOREGROUND_CANCELED = 7,
     // NOTE: insert new values above this line and update histogram enum too.
     STATUS_COUNT
   };
 
+  static std::string RequestStatusToString(RequestStatus request_status) {
+    switch (request_status) {
+      case UNKNOWN: return "Unknown";
+      case LOADED: return "LOADED";
+      case SAVED: return "SAVED";
+      case REQUEST_COORDINATOR_CANCELED: return "REQUEST_COORDINATOR_CANCELED";
+      case PRERENDERING_CANCELED: return "PRERENDERING_CANCELED";
+      case PRERENDERING_FAILED: return "PRERENDERING_FAILED";
+      case SAVE_FAILED: return "SAVE_FAILED";
+      case FOREGROUND_CANCELED: return "FOREGROUND_CANCELED";
+      case STATUS_COUNT: return "STATUS_COUNT";

[Pete Williamson, 2016/08/03 20:44:55]

SHould we really be returning a string for the count?  Any code that takes
advantage of this feature will be in for an ugly surprise.

[dougarnett, 2016/08/03 21:40:01]

update to DCHECK and empty string for non-Debug?

[Pete Williamson, 2016/08/03 22:29:12]

sounds good

[dougarnett, 2016/08/03 23:33:51]

Done.

+    }
+  }
+
   // Reports the completion status of a request.
   // TODO(dougarnett): consider passing back a request id instead of request.
   typedef base::Callback<void(const SavePageRequest&, RequestStatus)>
       CompletionCallback;
 
   Offliner() {}
   virtual ~Offliner() {}
 
   // Processes |request| to load and save an offline page.
   // Returns whether the request was accepted or not. |callback| is guaranteed
   // to be called if the request was accepted and |Cancel()| is not called.
   virtual bool LoadAndSave(
       const SavePageRequest& request,
       const CompletionCallback& callback) = 0;
 
   // Clears the currently processing request, if any, and skips running its
   // CompletionCallback.
   virtual void Cancel() = 0;
 
   // TODO(dougarnett): add policy support methods.
 };
 
 }  // namespace offline_pages
 
 #endif  // COMPONENTS_OFFLINE_PAGES_BACKGROUND_OFFLINER_H_