mash: Move ShelfWindowTargeter out of shelf_widget.cc

mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f
Cr-Commit-Position: refs/heads/master@{#409970}

[msw, 2016-08-04 19:49:18]

Description was changed from

==========
Move ShelfWindowTargeter out of shelf_widget.cc

BUG=615155
==========

to

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

BUG=615155
==========

[msw, 2016-08-04 21:59:02]

Description was changed from

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

BUG=615155
==========

to

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org
==========

[msw, 2016-08-04 21:59:02]

msw@chromium.org changed reviewers:
+ sky@chromium.org

[msw, 2016-08-04 22:07:47]

Hey Scott, please take a look; thanks!

[msw, 2016-08-04 22:07:51]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 22:08:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sky, 2016-08-04 23:12:19]

LGTM

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_targeter.cc (right):

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_targeter.cc:1: // Copyright 2012 The Chromium Authors.
All rights reserved.
2016

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_targeter.cc:37:
ShelfWindowTargeter::~ShelfWindowTargeter() {}
It would be nice if you could DCHECK OnWindowDestroying was called.

[commit-bot: I haz the power, 2016-08-04 23:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 23:57:57]

Dry run: This issue passed the CQ dry run.

[msw, 2016-08-05 01:39:52]

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
File ash/shelf/shelf_window_targeter.cc (right):

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_targeter.cc:1: // Copyright 2012 The Chromium Authors.
All rights reserved.
On 2016/08/04 23:12:19, sky wrote:
> 2016

Done.

https://codereview.chromium.org/2209803004/diff/40001/ash/shelf/shelf_window_...
ash/shelf/shelf_window_targeter.cc:37:
ShelfWindowTargeter::~ShelfWindowTargeter() {}
On 2016/08/04 23:12:19, sky wrote:
> It would be nice if you could DCHECK OnWindowDestroying was called.

Done.

[msw, 2016-08-05 01:39:56]

The CQ bit was checked by msw@chromium.org

[msw, 2016-08-05 01:39:56]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/2209803004/#ps60001
(title: "Address comments.")

[commit-bot: I haz the power, 2016-08-05 01:40:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 02:32:40]

Description was changed from

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org
==========

to

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-08-05 02:32:41]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-05 02:34:45]

Description was changed from

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org
==========

to

==========
mash: Move ShelfWindowTargeter out of shelf_widget.cc

Split out ash/shelf/shelf_window_targeter.[h|cc].
Make GetInsetsForAlignment a file-local helper.

Convert ShelfLayoutManagerObserver to WmShelfObserver.
Use WmWindowObserver to watch for destruction and remove.

Should help us prevent/delegate creation in Mus/Aura.

BUG=615155
TEST=No shelf/window event targeting behavior changes.
R=sky@chromium.org

Committed: https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f
Cr-Commit-Position: refs/heads/master@{#409970}
==========

[commit-bot: I haz the power, 2016-08-05 02:34:46]

Patchset 4 (id:??) landed as
https://crrev.com/45754f1c35ffffab564b60c87e299e28e0951d5f
Cr-Commit-Position: refs/heads/master@{#409970}