Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2209773003: [promises] remove duplicate var initialization (Closed)

Created:
4 years, 4 months ago by gsathya
Modified:
4 years, 4 months ago
Reviewers:
Dan Ehrenberg, adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[promises] remove duplicate var initialization BUG=v8:5046 Committed: https://crrev.com/80329cdd34c26887534480077be1882c2365b864 Cr-Commit-Position: refs/heads/master@{#38316}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/js/promise.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
gsathya
4 years, 4 months ago (2016-08-03 20:56:11 UTC) #7
adamk
lgtm
4 years, 4 months ago (2016-08-03 21:02:10 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209773003/1
4 years, 4 months ago (2016-08-03 22:00:12 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 22:02:19 UTC) #12
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 22:04:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/80329cdd34c26887534480077be1882c2365b864
Cr-Commit-Position: refs/heads/master@{#38316}

Powered by Google App Engine
This is Rietveld 408576698