Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTheme.cpp

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check if element is nullptr to fix the crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTheme.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
index c0b9e3c44ae1d4935873251449e013186a22961a..0facabd26e8ecfc2a122b375728c82b14bfcb81d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTheme.cpp
@@ -210,6 +210,12 @@ void LayoutTheme::adjustStyle(ComputedStyle& style, Element* e)
return adjustMenuListStyle(style, e);
case MenulistButtonPart:
return adjustMenuListButtonStyle(style, e);
+ case SliderHorizontalPart:
+ case SliderVerticalPart:
+ case MediaFullScreenVolumeSliderPart:
+ case MediaSliderPart:
+ case MediaVolumeSliderPart:
+ return adjustSliderContainerStyle(style, e);
case SliderThumbHorizontalPart:
case SliderThumbVerticalPart:
return adjustSliderThumbStyle(style);
@@ -627,6 +633,19 @@ void LayoutTheme::adjustMenuListButtonStyle(ComputedStyle&, Element*) const
{
}
+void LayoutTheme::adjustSliderContainerStyle(ComputedStyle& style, Element* e) const
+{
+ if (e && (e->shadowPseudoId() == "-webkit-media-slider-container" || e->shadowPseudoId() == "-webkit-slider-container")) {
+ if (style.appearance() == SliderVerticalPart) {
+ style.setTouchAction(TouchActionPanX);
+ style.setAppearance(NoControlPart);
+ } else {
+ style.setTouchAction(TouchActionPanY);
+ style.setAppearance(NoControlPart);
+ }
+ }
+}
+
void LayoutTheme::adjustSliderThumbStyle(ComputedStyle& style) const
{
adjustSliderThumbSize(style);
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTheme.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698