Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check if element is nullptr to fix the crash Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
diff --git a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
index ef06fa4719a2c66637f14f0da3b8ce1f9fd0edb4..b3225e0af5651b2f5860cb59d6069c1045c25a6e 100644
--- a/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
+++ b/third_party/WebKit/Source/core/html/shadow/SliderThumbElement.h
@@ -80,12 +80,31 @@ DEFINE_ELEMENT_TYPE_CASTS(SliderThumbElement, isHTMLElement());
class SliderContainerElement final : public HTMLDivElement {
public:
+ enum Direction {
+ Horizontal,
+ Vertical,
+ NoMove,
+ };
+
DECLARE_NODE_FACTORY(SliderContainerElement);
+ HTMLInputElement* hostInput() const;
+ void defaultEventHandler(Event*) override;
+ void handleTouchEvent(TouchEvent*);
+ void updateTouchEventHandlerRegistry();
+ void didMoveToNewDocument(Document&) override;
+ void removeAllEventListeners() override;
private:
explicit SliderContainerElement(Document&);
LayoutObject* createLayoutObject(const ComputedStyle&) override;
const AtomicString& shadowPseudoId() const override;
+ Direction getDirection(LayoutPoint&, LayoutPoint&);
+ bool canSlide();
+
+ bool m_hasTouchEventHandler;
+ bool m_touchStarted;
+ Direction m_slidingDirection;
+ LayoutPoint m_startPoint;
};
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698