third_party/WebKit/Source/core/html/HTMLInputElement.h - Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Check if element is nullptr to fix the crash Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input.html ('k') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLInputElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLInputElement.h b/third_party/WebKit/Source/core/html/HTMLInputElement.h

index 6e61b826b18ddd085241f1ff3705ae81ece4aecf..fd9bea014b8dd76a2f774a768141f477da7d6ecc 100644

--- a/third_party/WebKit/Source/core/html/HTMLInputElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLInputElement.h

@@ -287,7 +287,6 @@ private:

InsertionNotificationRequest insertedInto(ContainerNode*) override;

void removedFrom(ContainerNode*) final;

void didMoveToNewDocument(Document& oldDocument) final;

- void removeAllEventListeners() final;

bool hasCustomFocusLogic() const final;

bool isKeyboardFocusable() const final;

@@ -357,7 +356,6 @@ private:

void requiredAttributeChanged() final;

void disabledAttributeChanged() final;

- void updateTouchEventHandlerRegistry();

void initializeTypeInParsing();

void updateType();

@@ -395,7 +393,6 @@ private:

unsigned m_parsingInProgress : 1;

unsigned m_valueAttributeWasUpdatedAfterParsing : 1;

unsigned m_canReceiveDroppedFiles : 1;

- unsigned m_hasTouchEventHandler : 1;

unsigned m_shouldRevealPassword : 1;

unsigned m_needsToUpdateViewValue : 1;

unsigned m_isPlaceholderVisible : 1;