third_party/WebKit/Source/core/html/forms/RangeInputType.cpp - Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use better functions, structures and names Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/events/touch/touch-action-range-input.html ('K') | « third_party/WebKit/Source/core/html/forms/RangeInputType.h ('k') | third_party/WebKit/Source/core/layout/LayoutTheme.h » ('j') | third_party/WebKit/Source/core/layout/LayoutTheme.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

index e91b6744e21b01b7d9fde5abab14d158326bc22a..c5cf2357cef2df8a747298a0e9d4ef859495857d 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

@@ -182,11 +182,10 @@ void RangeInputType::handleTouchEvent(TouchEvent* event)

TouchList* touches = event->targetTouches();

if (touches->length() == 1) {

sliderThumbElement()->setPositionFromPoint(touches->item(0)->absoluteLocation());

- event->setDefaultHandled();

}

-bool RangeInputType::hasTouchEventHandler() const

+bool RangeInputType::hasPassiveTouchEventHandler() const

{

return true;

}