Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
index e91b6744e21b01b7d9fde5abab14d158326bc22a..53145075ae359ac8311e71bddd980fd77f6ca83d 100644
--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp
@@ -186,9 +186,9 @@ void RangeInputType::handleTouchEvent(TouchEvent* event)
}
}
-bool RangeInputType::hasTouchEventHandler() const
+TouchHandlerType RangeInputType::hasTouchEventHandler() const
{
- return true;
+ return Passive;
}
void RangeInputType::handleKeydownEvent(KeyboardEvent* event)
@@ -259,6 +259,7 @@ void RangeInputType::createShadowSubtree()
HTMLDivElement* track = HTMLDivElement::create(document);
track->setShadowPseudoId(AtomicString("-webkit-slider-runnable-track"));
track->setAttribute(idAttr, ShadowElementNames::sliderTrack());
+ track->setAttribute(styleAttr, "pan-y pinch-zoom");
majidvp 2016/08/03 18:01:06 Using the style attribute seems reasonable. Howev
track->appendChild(SliderThumbElement::create(document));
HTMLElement* container = SliderContainerElement::create(document);
container->appendChild(track);

Powered by Google App Engine
This is Rietveld 408576698