Remove the blocking touch handlers for the input[type=range] and add touch-action instead

third_party/WebKit/Source/core/html/HTMLInputElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  *           (C) 2006 Alexey Proskuryakov (ap@nypop.com)
  * Copyright (C) 2007 Samuel Weinig (sam@webkit.org)
  * Copyright (C) 2010 Google Inc. All rights reserved.
  * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2012 Samsung Electronics. All rights reserved.
@@ skipping 95 matching lines @@
     , m_isChecked(false)
     , m_dirtyCheckedness(false)
     , m_isIndeterminate(false)
     , m_isActivatedSubmit(false)
     , m_autocomplete(Uninitialized)
     , m_hasNonEmptyList(false)
     , m_stateRestored(false)
     , m_parsingInProgress(createdByParser)
     , m_valueAttributeWasUpdatedAfterParsing(false)
     , m_canReceiveDroppedFiles(false)
-    , m_hasTouchEventHandler(false)
     , m_shouldRevealPassword(false)
     , m_needsToUpdateViewValue(true)
     , m_isPlaceholderVisible(false)
+    , m_touchEventHandlerType(NoHandler)
     // |m_inputType| is lazily created when constructed by the parser to avoid
     // constructing unnecessarily a text inputType and its shadow subtree, just
     // to destroy them when the |type| attribute gets set by the parser to
     // something else than 'text'.
     , m_inputType(createdByParser ? nullptr : InputType::createText(*this))
     , m_inputTypeView(m_inputType ? m_inputType->createView() : nullptr)
 {
     setHasCustomStyleCallbacks();
 }
 
@@ skipping 268 matching lines @@
 
 void HTMLInputElement::setType(const AtomicString& type)
 {
     setAttribute(typeAttr, type);
 }
 
 void HTMLInputElement::updateTouchEventHandlerRegistry()
 {
     ASSERT(m_inputTypeView);
 
-    bool hasTouchEventHandler = m_inputTypeView->hasTouchEventHandler();
-    if (hasTouchEventHandler == !!m_hasTouchEventHandler)
+    TouchHandlerType touchEventHandlerType = m_inputTypeView->touchEventHandlerType();
+    if (touchEventHandlerType == m_touchEventHandlerType)
         return;
     // If the Document is being or has been stopped, don't register any handlers.
     if (document().frameHost() && document().lifecycle().state() < DocumentLifecycle::Stopping) {
         EventHandlerRegistry& registry = document().frameHost()->eventHandlerRegistry();
         // TODO(dtapuska): Make this passive touch listener see crbug.com/584438

[majidvp, 2016/08/04 21:21:58]

I think this TODO is no longer applicable once you land this. Please remove.

-        if (hasTouchEventHandler)
-            registry.didAddEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventBlocking);
+        if (touchEventHandlerType == Passive)
+            registry.didAddEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventPassive);
         else
-            registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventBlocking);
-        m_hasTouchEventHandler = hasTouchEventHandler;
+            registry.didRemoveEventHandler(*this, EventHandlerRegistry::TouchStartOrMoveEventPassive);
+        m_touchEventHandlerType = touchEventHandlerType;
     }
 }
 
 void HTMLInputElement::initializeTypeInParsing()
 {
     ASSERT(m_parsingInProgress);
     ASSERT(!m_inputType);
     ASSERT(!m_inputTypeView);
 
     const AtomicString& newTypeName = InputType::normalizeTypeName(fastGetAttribute(typeAttr));
@@ skipping 724 matching lines @@
 }
 
 void HTMLInputElement::defaultEventHandler(Event* evt)
 {
     if (evt->isMouseEvent() && evt->type() == EventTypeNames::click && toMouseEvent(evt)->button() == LeftButton) {
         m_inputTypeView->handleClickEvent(toMouseEvent(evt));
         if (evt->defaultHandled())
             return;
     }
 
-    if (evt->isTouchEvent() && m_inputTypeView->hasTouchEventHandler()) {
+    if (evt->isTouchEvent() && m_inputTypeView->touchEventHandlerType() == Passive) {
         m_inputTypeView->handleTouchEvent(toTouchEvent(evt));
         if (evt->defaultHandled())
             return;
     }
 
     if (evt->isKeyboardEvent() && evt->type() == EventTypeNames::keydown) {
         m_inputTypeView->handleKeydownEvent(toKeyboardEvent(evt));
         if (evt->defaultHandled())
             return;
     }
@@ skipping 332 matching lines @@
         treeScope().radioButtonGroupScope().removeButton(this);
 
     updateTouchEventHandlerRegistry();
 
     HTMLTextFormControlElement::didMoveToNewDocument(oldDocument);
 }
 
 void HTMLInputElement::removeAllEventListeners()
 {
     HTMLTextFormControlElement::removeAllEventListeners();
-    m_hasTouchEventHandler = false;
+    m_touchEventHandlerType = NoHandler;
 }
 
 bool HTMLInputElement::recalcWillValidate() const
 {
     return m_inputType->supportsValidation() && HTMLTextFormControlElement::recalcWillValidate();
 }
 
 void HTMLInputElement::requiredAttributeChanged()
 {
     HTMLTextFormControlElement::requiredAttributeChanged();
@@ skipping 386 matching lines @@
 {
     return m_inputTypeView->hasFallbackContent();
 }
 
 void HTMLInputElement::setFilesFromPaths(const Vector<String>& paths)
 {
     return m_inputType->setFilesFromPaths(paths);
 }
 
 } // namespace blink