Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLInputElement.h

Issue 2209773002: Remove the blocking touch handlers for the input[type=range] and add touch-action instead (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better code style Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2005, 2006, 2007, 2010 Apple Inc. All rights reserved.
6 * Copyright (C) 2012 Samsung Electronics. All rights reserved. 6 * Copyright (C) 2012 Samsung Electronics. All rights reserved.
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 269 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 private: 280 private:
281 enum AutoCompleteSetting { Uninitialized, On, Off }; 281 enum AutoCompleteSetting { Uninitialized, On, Off };
282 282
283 void didAddUserAgentShadowRoot(ShadowRoot&) final; 283 void didAddUserAgentShadowRoot(ShadowRoot&) final;
284 284
285 void willChangeForm() final; 285 void willChangeForm() final;
286 void didChangeForm() final; 286 void didChangeForm() final;
287 InsertionNotificationRequest insertedInto(ContainerNode*) override; 287 InsertionNotificationRequest insertedInto(ContainerNode*) override;
288 void removedFrom(ContainerNode*) final; 288 void removedFrom(ContainerNode*) final;
289 void didMoveToNewDocument(Document& oldDocument) final; 289 void didMoveToNewDocument(Document& oldDocument) final;
290 void removeAllEventListeners() final;
291 290
292 bool hasCustomFocusLogic() const final; 291 bool hasCustomFocusLogic() const final;
293 bool isKeyboardFocusable() const final; 292 bool isKeyboardFocusable() const final;
294 bool shouldShowFocusRingOnMouseFocus() const final; 293 bool shouldShowFocusRingOnMouseFocus() const final;
295 bool isEnumeratable() const final; 294 bool isEnumeratable() const final;
296 bool isInteractiveContent() const final; 295 bool isInteractiveContent() const final;
297 bool supportLabels() const final; 296 bool supportLabels() const final;
298 bool matchesDefaultPseudoClass() const override; 297 bool matchesDefaultPseudoClass() const override;
299 298
300 bool isTextFormControl() const final { return isTextField(); } 299 bool isTextFormControl() const final { return isTextField(); }
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
350 void dispatchFocusInEvent(const AtomicString& eventType, Element* oldFocused Element, WebFocusType, InputDeviceCapabilities* sourceCapabilities) final; 349 void dispatchFocusInEvent(const AtomicString& eventType, Element* oldFocused Element, WebFocusType, InputDeviceCapabilities* sourceCapabilities) final;
351 bool supportsAutocapitalize() const final; 350 bool supportsAutocapitalize() const final;
352 const AtomicString& defaultAutocapitalize() const final; 351 const AtomicString& defaultAutocapitalize() const final;
353 352
354 bool isOptionalFormControl() const final { return !isRequiredFormControl(); } 353 bool isOptionalFormControl() const final { return !isRequiredFormControl(); }
355 bool isRequiredFormControl() const final; 354 bool isRequiredFormControl() const final;
356 bool recalcWillValidate() const final; 355 bool recalcWillValidate() const final;
357 void requiredAttributeChanged() final; 356 void requiredAttributeChanged() final;
358 void disabledAttributeChanged() final; 357 void disabledAttributeChanged() final;
359 358
360 void updateTouchEventHandlerRegistry();
361 void initializeTypeInParsing(); 359 void initializeTypeInParsing();
362 void updateType(); 360 void updateType();
363 361
364 void subtreeHasChanged() final; 362 void subtreeHasChanged() final;
365 363
366 void setListAttributeTargetObserver(ListAttributeTargetObserver*); 364 void setListAttributeTargetObserver(ListAttributeTargetObserver*);
367 void resetListAttributeTargetObserver(); 365 void resetListAttributeTargetObserver();
368 void parseMaxLengthAttribute(const AtomicString&); 366 void parseMaxLengthAttribute(const AtomicString&);
369 void parseMinLengthAttribute(const AtomicString&); 367 void parseMinLengthAttribute(const AtomicString&);
370 void updateValueIfNeeded(); 368 void updateValueIfNeeded();
(...skipping 17 matching lines...) Expand all
388 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-d irty-flag 386 // https://html.spec.whatwg.org/multipage/forms.html#concept-input-checked-d irty-flag
389 unsigned m_dirtyCheckedness : 1; 387 unsigned m_dirtyCheckedness : 1;
390 unsigned m_isIndeterminate : 1; 388 unsigned m_isIndeterminate : 1;
391 unsigned m_isActivatedSubmit : 1; 389 unsigned m_isActivatedSubmit : 1;
392 unsigned m_autocomplete : 2; // AutoCompleteSetting 390 unsigned m_autocomplete : 2; // AutoCompleteSetting
393 unsigned m_hasNonEmptyList : 1; 391 unsigned m_hasNonEmptyList : 1;
394 unsigned m_stateRestored : 1; 392 unsigned m_stateRestored : 1;
395 unsigned m_parsingInProgress : 1; 393 unsigned m_parsingInProgress : 1;
396 unsigned m_valueAttributeWasUpdatedAfterParsing : 1; 394 unsigned m_valueAttributeWasUpdatedAfterParsing : 1;
397 unsigned m_canReceiveDroppedFiles : 1; 395 unsigned m_canReceiveDroppedFiles : 1;
398 unsigned m_hasTouchEventHandler : 1;
399 unsigned m_shouldRevealPassword : 1; 396 unsigned m_shouldRevealPassword : 1;
400 unsigned m_needsToUpdateViewValue : 1; 397 unsigned m_needsToUpdateViewValue : 1;
401 unsigned m_isPlaceholderVisible : 1; 398 unsigned m_isPlaceholderVisible : 1;
402 Member<InputType> m_inputType; 399 Member<InputType> m_inputType;
403 Member<InputTypeView> m_inputTypeView; 400 Member<InputTypeView> m_inputTypeView;
404 // The ImageLoader must be owned by this element because the loader code ass umes 401 // The ImageLoader must be owned by this element because the loader code ass umes
405 // that it lives as long as its owning element lives. If we move the loader into 402 // that it lives as long as its owning element lives. If we move the loader into
406 // the ImageInput object we may delete the loader while this element lives o n. 403 // the ImageInput object we may delete the loader while this element lives o n.
407 Member<HTMLImageLoader> m_imageLoader; 404 Member<HTMLImageLoader> m_imageLoader;
408 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver; 405 Member<ListAttributeTargetObserver> m_listAttributeTargetObserver;
409 }; 406 };
410 407
411 } // namespace blink 408 } // namespace blink
412 409
413 #endif // HTMLInputElement_h 410 #endif // HTMLInputElement_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698