Issue 2209733002: [mojo-edk] Prevent AcceptIncomingMessages flushing aggressively

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2209733002: [mojo-edk] Prevent AcceptIncomingMessages flushing aggressively (Closed)

Created:
4 years, 4 months ago by Ken Rockot(use gerrit already)

Modified:
4 years, 4 months ago

Reviewers:
Anand Mistry (off Chromium)

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2785

Target Ref:
refs/pending/branch-heads/2785

Project:
chromium

Visibility:
Public.

More Reviews

Description

[mojo-edk] Prevent AcceptIncomingMessages flushing aggressively Changes AcceptIncomingMessages to only flush the incoming message queue once synchronously. This prevents deadlock cycles that can block incoming external messages by spinning the IO thread indefinitely. It also prevents similar cycles from chewing up CPU on other threads. Also fixes some Watcher tests that are broken by ProcessIncomingMessages behavior. This change made the brokenness more apparent. BUG=628492 R=amistry@chromium.org Review-Url: https://codereview.chromium.org/2153733002 Cr-Commit-Position: refs/heads/master@{#405776} TBR=yzshen@chromium.org

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -32 lines)			Patch
M	mojo/edk/system/node_controller.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	mojo/edk/system/node_controller.cc	View	2 chunks	+14 lines, -22 lines	0 comments	Download
M	mojo/edk/system/watch_unittest.cc	View	8 chunks	+23 lines, -8 lines	0 comments	Download

Messages

Total messages: 1 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Ken Rockot(use gerrit already)

4 years, 4 months ago (2016-08-03 16:10:33 UTC) #1

Description was changed from

==========
[mojo-edk] Prevent AcceptIncomingMessages flushing aggressively

Changes AcceptIncomingMessages to only flush the incoming
message queue once synchronously. This prevents deadlock cycles
that can block incoming external messages by spinning the IO
thread indefinitely. It also prevents similar cycles from
chewing up CPU on other threads.

Also fixes some Watcher tests that are broken by
ProcessIncomingMessages behavior. This change made the
brokenness more apparent.

BUG=628492
R=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2153733002
Cr-Commit-Position: refs/heads/master@{#405776}
==========

to

==========
[mojo-edk] Prevent AcceptIncomingMessages flushing aggressively

Changes AcceptIncomingMessages to only flush the incoming
message queue once synchronously. This prevents deadlock cycles
that can block incoming external messages by spinning the IO
thread indefinitely. It also prevents similar cycles from
chewing up CPU on other threads.

Also fixes some Watcher tests that are broken by
ProcessIncomingMessages behavior. This change made the
brokenness more apparent.

BUG=628492
R=amistry@chromium.org

Review-Url: https://codereview.chromium.org/2153733002
Cr-Commit-Position: refs/heads/master@{#405776}

TBR=yzshen@chromium.org
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages