Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 2209703002: gn: Don't depend on osmesa. (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke, sdefresne
CC:
chromium-reviews, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Don't depend on osmesa on iOS. It's not needed there, and it doesn't quite build. It's only pulled in accidentally via the events_unittests data_dep, but events_unittests.isolate depends on osmesa only on desktop. So match that. BUG=633316 R=dpranke@chromium.org, sdefresne@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/410dc80e6cefc05a8c5e4cb32f13c64968ad5bf3

Patch Set 1 #

Patch Set 2 : asdfadsfa #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M third_party/mesa/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/BUILD.gn View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Nico
4 years, 4 months ago (2016-08-03 15:20:35 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-03 15:22:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209703002/20001
4 years, 4 months ago (2016-08-03 15:26:38 UTC) #8
sdefresne
lgtm
4 years, 4 months ago (2016-08-03 16:26:15 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/410dc80e6cefc05a8c5e4cb32f13c64968ad5bf3 Cr-Commit-Position: refs/heads/master@{#409538}
4 years, 4 months ago (2016-08-03 16:51:49 UTC) #11
commit-bot: I haz the power
Failed to apply the patch.
4 years, 4 months ago (2016-08-03 16:52:07 UTC) #12
Nico
4 years, 4 months ago (2016-08-03 16:52:53 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
410dc80e6cefc05a8c5e4cb32f13c64968ad5bf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698