Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2209673002: Remove non essential weak next_* links from the heap snapshot. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove non essential weak next_* links from the heap snapshot. Remove the 'next' link for Code, JSFunction, and Context. Committed: https://crrev.com/09954144b08f4582805db5399b0c234b80526064 Cr-Commit-Position: refs/heads/master@{#38303}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M src/profiler/heap-snapshot-generator.cc View 5 chunks +13 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
4 years, 4 months ago (2016-08-03 13:57:11 UTC) #2
ulan
lgtm
4 years, 4 months ago (2016-08-03 14:00:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209673002/1
4 years, 4 months ago (2016-08-03 14:58:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 14:59:46 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 15:02:42 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09954144b08f4582805db5399b0c234b80526064
Cr-Commit-Position: refs/heads/master@{#38303}

Powered by Google App Engine
This is Rietveld 408576698