Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 2209663003: Fix several stack-traces tests using assertUnreachable() (Closed)

Created:
4 years, 4 months ago by jgruber
Modified:
4 years, 4 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix several stack-traces tests using assertUnreachable() These tests all called assertUnreachable within a try/catch block. BUG=v8:5246 Committed: https://crrev.com/76193d4b6c08966e83e3a10d9370c374c542b97e Cr-Commit-Position: refs/heads/master@{#38323}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M test/mjsunit/stack-traces.js View 2 chunks +11 lines, -9 lines 1 comment Download

Messages

Total messages: 12 (7 generated)
jgruber
https://codereview.chromium.org/2209663003/diff/1/test/mjsunit/stack-traces.js File test/mjsunit/stack-traces.js (left): https://codereview.chromium.org/2209663003/diff/1/test/mjsunit/stack-traces.js#oldcode313 test/mjsunit/stack-traces.js:313: error.name = { toString: function() { assertUnreachable(); }}; This ...
4 years, 4 months ago (2016-08-03 16:20:28 UTC) #6
Yang
lgtm
4 years, 4 months ago (2016-08-04 06:57:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209663003/1
4 years, 4 months ago (2016-08-04 07:14:32 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 07:19:18 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 07:22:22 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/76193d4b6c08966e83e3a10d9370c374c542b97e
Cr-Commit-Position: refs/heads/master@{#38323}

Powered by Google App Engine
This is Rietveld 408576698