test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc - Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition.

Unified Diff: test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Rebased the patch. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/unittests/interpreter/bytecode-array-iterator-unittest.cc ('k') | test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc b/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

index 915c23dad394c12115b2d84bb4472de255410ed7..8560adc6db3a23205c81da6a817fd9e22625831d 100644

--- a/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

+++ b/test/unittests/interpreter/bytecode-dead-code-optimizer-unittest.cc

@@ -50,7 +50,7 @@ class BytecodeDeadCodeOptimizerTest : public BytecodePipelineStage,

};

TEST_F(BytecodeDeadCodeOptimizerTest, LiveCodeKept) {

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(add, last_written());

@@ -68,7 +68,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeAfterReturnEliminated) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(ret, last_written());

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(ret, last_written());

@@ -80,7 +80,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeAfterThrowEliminated) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(thrw, last_written());

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(thrw, last_written());

@@ -92,7 +92,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeAfterReThrowEliminated) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(rethrow, last_written());

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(rethrow, last_written());

@@ -105,7 +105,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeAfterJumpEliminated) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(jump, last_written());

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(jump, last_written());

@@ -123,7 +123,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, DeadCodeStillDeadAfterConditinalJump) {

CHECK_EQ(write_count(), 1);

CHECK_EQ(ret, last_written());

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 1);

CHECK_EQ(ret, last_written());

@@ -138,7 +138,7 @@ TEST_F(BytecodeDeadCodeOptimizerTest, CodeLiveAfterLabelBind) {

BytecodeLabel target;

optimizer()->BindLabel(&target);

- BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());

+ BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);

optimizer()->Write(&add);

CHECK_EQ(write_count(), 2);

CHECK_EQ(add, last_written());