Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden

Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/bytecode-generator.cc ('K') | « test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden ('k') | test/cctest/interpreter/bytecode_expectations/BasicLoops.golden » ('j') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden b/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden
index 960c36818564f9de0f1898cb2f6ae2f3f62573ac..c2c5336efdcb20ee61b3d4784daf7bc6f07d1032 100644
--- a/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden
+++ b/test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden
@@ -68,7 +68,7 @@ snippet: "
"
frame size: 3
parameter count: 1
-bytecode array length: 26
+bytecode array length: 28
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(55),
@@ -76,11 +76,11 @@ bytecodes: [
/* 46 S> */ B(LdaSmi), U8(100),
B(Mov), R(0), R(1),
B(Star), R(0),
- /* 57 E> */ B(Add), R(1),
+ /* 57 E> */ B(Add), R(1), U8(1),
B(Star), R(2),
B(LdaSmi), U8(101),
B(Star), R(0),
- /* 69 E> */ B(Add), R(2),
+ /* 69 E> */ B(Add), R(2), U8(2),
B(Star), R(0),
/* 77 S> */ B(Nop),
/* 87 S> */ B(Return),
@@ -99,20 +99,20 @@ snippet: "
"
frame size: 3
parameter count: 1
-bytecode array length: 26
+bytecode array length: 29
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(55),
B(Star), R(0),
/* 46 S> */ B(LdaSmi), U8(56),
B(Star), R(0),
- /* 61 E> */ B(Sub), R(0),
+ /* 61 E> */ B(Sub), R(0), U8(1),
B(Star), R(2),
B(LdaSmi), U8(57),
B(Star), R(0),
- /* 68 E> */ B(Add), R(2),
+ /* 68 E> */ B(Add), R(2), U8(2),
B(Star), R(0),
- /* 75 S> */ B(Inc),
+ /* 75 S> */ B(Inc), U8(3),
B(Star), R(0),
/* 80 S> */ B(Nop),
/* 90 S> */ B(Return),
@@ -130,7 +130,7 @@ snippet: "
"
frame size: 4
parameter count: 1
-bytecode array length: 34
+bytecode array length: 37
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(55),
@@ -138,15 +138,15 @@ bytecodes: [
/* 76 S> */ B(LdaSmi), U8(1),
B(Mov), R(0), R(2),
B(Star), R(0),
- /* 61 E> */ B(Add), R(2),
+ /* 61 E> */ B(Add), R(2), U8(1),
B(Star), R(3),
B(LdaSmi), U8(2),
B(Star), R(0),
- /* 71 E> */ B(Add), R(3),
+ /* 71 E> */ B(Add), R(3), U8(2),
B(Star), R(2),
B(LdaSmi), U8(3),
B(Star), R(0),
- /* 81 E> */ B(Add), R(2),
+ /* 81 E> */ B(Add), R(2), U8(3),
B(Star), R(1),
/* 87 S> */ B(Nop),
/* 97 S> */ B(Return),
@@ -164,7 +164,7 @@ snippet: "
"
frame size: 3
parameter count: 1
-bytecode array length: 34
+bytecode array length: 37
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(55),
@@ -172,15 +172,15 @@ bytecodes: [
/* 76 S> */ B(LdaSmi), U8(1),
B(Mov), R(0), R(1),
B(Star), R(0),
- /* 61 E> */ B(Add), R(1),
+ /* 61 E> */ B(Add), R(1), U8(1),
B(Star), R(2),
B(LdaSmi), U8(2),
B(Star), R(0),
- /* 71 E> */ B(Add), R(2),
+ /* 71 E> */ B(Add), R(2), U8(2),
B(Star), R(1),
B(LdaSmi), U8(3),
B(Star), R(0),
- /* 81 E> */ B(Add), R(1),
+ /* 81 E> */ B(Add), R(1), U8(3),
B(Star), R(0),
/* 87 S> */ B(Nop),
/* 97 S> */ B(Return),
@@ -197,7 +197,7 @@ snippet: "
"
frame size: 5
parameter count: 1
-bytecode array length: 64
+bytecode array length: 71
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(10),
@@ -207,29 +207,29 @@ bytecodes: [
/* 54 S> */ B(LdaSmi), U8(1),
B(Mov), R(0), R(2),
B(Star), R(0),
- /* 68 E> */ B(Add), R(2),
+ /* 68 E> */ B(Add), R(2), U8(1),
B(Star), R(3),
/* 76 E> */ B(AddSmi), U8(1), R(0),
B(Star), R(4),
B(LdaSmi), U8(2),
B(Star), R(1),
- /* 88 E> */ B(Mul), R(4),
- B(Add), R(3),
+ /* 88 E> */ B(Mul), R(4), U8(3),
+ B(Add), R(3), U8(4),
B(Star), R(2),
B(LdaSmi), U8(3),
B(Star), R(1),
- /* 98 E> */ B(Add), R(2),
+ /* 98 E> */ B(Add), R(2), U8(5),
B(Star), R(3),
B(LdaSmi), U8(4),
B(Star), R(0),
- /* 108 E> */ B(Add), R(3),
+ /* 108 E> */ B(Add), R(3), U8(6),
B(Star), R(2),
B(LdaSmi), U8(5),
B(Star), R(1),
- /* 118 E> */ B(Add), R(2),
+ /* 118 E> */ B(Add), R(2), U8(7),
B(Star), R(3),
B(Ldar), R(1),
- /* 125 E> */ B(Add), R(3),
+ /* 125 E> */ B(Add), R(3), U8(8),
/* 128 S> */ B(Return),
]
constant pool: [
@@ -244,7 +244,7 @@ snippet: "
"
frame size: 4
parameter count: 1
-bytecode array length: 36
+bytecode array length: 41
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(17),
@@ -252,19 +252,19 @@ bytecodes: [
/* 46 S> */ B(LdaSmi), U8(1),
B(Star), R(1),
B(Ldar), R(0),
- /* 57 E> */ B(Add), R(1),
+ /* 57 E> */ B(Add), R(1), U8(1),
B(Star), R(2),
B(Ldar), R(0),
B(ToNumber), R(1),
- B(Inc),
+ B(Inc), U8(2),
B(Star), R(0),
B(Ldar), R(1),
- /* 63 E> */ B(Add), R(2),
+ /* 63 E> */ B(Add), R(2), U8(3),
B(Star), R(3),
B(Ldar), R(0),
- B(Inc),
+ B(Inc), U8(4),
B(Star), R(0),
- /* 72 E> */ B(Add), R(3),
+ /* 72 E> */ B(Add), R(3), U8(5),
/* 76 S> */ B(Return),
]
constant pool: [
« src/interpreter/bytecode-generator.cc ('K') | « test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden ('k') | test/cctest/interpreter/bytecode_expectations/BasicLoops.golden » ('j') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698