src/interpreter/bytecodes.h - Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition.

Unified Diff: src/interpreter/bytecodes.h

Issue 2209633002: [Interpreter] Assign feedback slots for binary operations and use them in ignition. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-generator.cc ('K') | « src/interpreter/bytecode-generator.cc ('k') | test/cctest/interpreter/bytecode_expectations/ArrayLiterals.golden » ('j') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index 57b1b1b2f3387413aeb4f645a4f0adb59422ddd0..c9014ae91d1761ae0649fbc270d6a64491ee4911 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -146,17 +146,23 @@ namespace interpreter {

OperandType::kReg, OperandType::kIdx) \

/* Binary Operators */ \

- V(Add, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(Sub, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(Mul, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(Div, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(Mod, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(BitwiseOr, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(BitwiseXor, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(BitwiseAnd, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(ShiftLeft, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(ShiftRight, AccumulatorUse::kReadWrite, OperandType::kReg) \

- V(ShiftRightLogical, AccumulatorUse::kReadWrite, OperandType::kReg) \

+ V(Add, AccumulatorUse::kReadWrite, OperandType::kReg, OperandType::kIdx) \

+ V(Sub, AccumulatorUse::kReadWrite, OperandType::kReg, OperandType::kIdx) \

+ V(Mul, AccumulatorUse::kReadWrite, OperandType::kReg, OperandType::kIdx) \

+ V(Div, AccumulatorUse::kReadWrite, OperandType::kReg, OperandType::kIdx) \

+ V(Mod, AccumulatorUse::kReadWrite, OperandType::kReg, OperandType::kIdx) \

+ V(BitwiseOr, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

+ V(BitwiseXor, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

+ V(BitwiseAnd, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

+ V(ShiftLeft, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

+ V(ShiftRight, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

+ V(ShiftRightLogical, AccumulatorUse::kReadWrite, OperandType::kReg, \

+ OperandType::kIdx) \

/* Binary operators with immediate operands */ \

V(AddSmi, AccumulatorUse::kWrite, OperandType::kImm, OperandType::kReg) \

@@ -171,8 +177,8 @@ namespace interpreter {

OperandType::kReg) \

/* Unary Operators */ \

- V(Inc, AccumulatorUse::kReadWrite) \

- V(Dec, AccumulatorUse::kReadWrite) \

+ V(Inc, AccumulatorUse::kReadWrite, OperandType::kIdx) \

+ V(Dec, AccumulatorUse::kReadWrite, OperandType::kIdx) \

V(ToBooleanLogicalNot, AccumulatorUse::kReadWrite) \

V(LogicalNot, AccumulatorUse::kReadWrite) \

V(TypeOf, AccumulatorUse::kReadWrite) \