[Interpreter] Assign feedback slots for binary operations and use them in ignition.

test/unittests/interpreter/bytecode-peephole-optimizer-unittest.cc

 // Copyright 2016 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/v8.h"
 
 #include "src/factory.h"
 #include "src/interpreter/bytecode-label.h"
 #include "src/interpreter/bytecode-peephole-optimizer.h"
 #include "src/interpreter/constant-array-builder.h"
@@ skipping 52 matching lines @@
 
   int write_count_ = 0;
   BytecodeNode last_written_;
 };
 
 // Sanity tests.
 
 TEST_F(BytecodePeepholeOptimizerTest, FlushOnJump) {
   CHECK_EQ(write_count(), 0);
 
-  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());
+  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);
   optimizer()->Write(&add);
   CHECK_EQ(write_count(), 0);
 
   BytecodeLabel target;
   BytecodeNode jump(Bytecode::kJump, 0);
   optimizer()->WriteJump(&jump, &target);
   CHECK_EQ(write_count(), 2);
   CHECK_EQ(jump, last_written());
 }
 
 TEST_F(BytecodePeepholeOptimizerTest, FlushOnBind) {
   CHECK_EQ(write_count(), 0);
 
-  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());
+  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);
   optimizer()->Write(&add);
   CHECK_EQ(write_count(), 0);
 
   BytecodeLabel target;
   optimizer()->BindLabel(&target);
   CHECK_EQ(write_count(), 1);
   CHECK_EQ(add, last_written());
 }
 
 // Nop elimination tests.
 
 TEST_F(BytecodePeepholeOptimizerTest, ElideEmptyNop) {
   BytecodeNode nop(Bytecode::kNop);
   optimizer()->Write(&nop);
-  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());
+  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);
   optimizer()->Write(&add);
   Flush();
   CHECK_EQ(write_count(), 1);
   CHECK_EQ(add, last_written());
 }
 
 TEST_F(BytecodePeepholeOptimizerTest, ElideExpressionNop) {
   BytecodeNode nop(Bytecode::kNop);
   nop.source_info().MakeExpressionPosition(3);
   optimizer()->Write(&nop);
-  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());
+  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);
   optimizer()->Write(&add);
   Flush();
   CHECK_EQ(write_count(), 1);
   CHECK_EQ(add, last_written());
 }
 
 TEST_F(BytecodePeepholeOptimizerTest, KeepStatementNop) {
   BytecodeNode nop(Bytecode::kNop);
   nop.source_info().MakeStatementPosition(3);
   optimizer()->Write(&nop);
-  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand());
+  BytecodeNode add(Bytecode::kAdd, Register(0).ToOperand(), 1);
   add.source_info().MakeExpressionPosition(3);
   optimizer()->Write(&add);
   Flush();
   CHECK_EQ(write_count(), 2);
   CHECK_EQ(add, last_written());
 }
 
 // Tests covering BytecodePeepholeOptimizer::UpdateCurrentBytecode().
 
 TEST_F(BytecodePeepholeOptimizerTest, KeepJumpIfToBooleanTrue) {
@@ skipping 352 matching lines @@
       {Bytecode::kBitwiseAnd, Bytecode::kBitwiseAndSmi},
       {Bytecode::kBitwiseOr, Bytecode::kBitwiseOrSmi},
       {Bytecode::kShiftLeft, Bytecode::kShiftLeftSmi},
       {Bytecode::kShiftRight, Bytecode::kShiftRightSmi}};
 
   for (auto operator_replacement : operator_replacement_pairs) {
     uint32_t imm_operand = 17;
     BytecodeNode first(Bytecode::kLdaSmi, imm_operand);
     first.source_info().Clone({3, true});
     uint32_t reg_operand = Register(0).ToOperand();
-    BytecodeNode second(operator_replacement[0], reg_operand);
+    BytecodeNode second(operator_replacement[0], reg_operand, 1);
     optimizer()->Write(&first);
     optimizer()->Write(&second);
     Flush();
     CHECK_EQ(write_count(), 1);
     CHECK_EQ(last_written().bytecode(), operator_replacement[1]);
     CHECK_EQ(last_written().operand_count(), 2);
     CHECK_EQ(last_written().operand(0), imm_operand);
     CHECK_EQ(last_written().operand(1), reg_operand);
     CHECK_EQ(last_written().source_info(), first.source_info());
     Reset();
   }
 }
 
 TEST_F(BytecodePeepholeOptimizerTest, NotMergingLdaSmiWithBinaryOp) {
   Bytecode operator_replacement_pairs[][2] = {
       {Bytecode::kAdd, Bytecode::kAddSmi},
       {Bytecode::kSub, Bytecode::kSubSmi},
       {Bytecode::kBitwiseAnd, Bytecode::kBitwiseAndSmi},
       {Bytecode::kBitwiseOr, Bytecode::kBitwiseOrSmi},
       {Bytecode::kShiftLeft, Bytecode::kShiftLeftSmi},
       {Bytecode::kShiftRight, Bytecode::kShiftRightSmi}};
 
   for (auto operator_replacement : operator_replacement_pairs) {
     uint32_t imm_operand = 17;
     BytecodeNode first(Bytecode::kLdaSmi, imm_operand);
     first.source_info().Clone({3, true});
     uint32_t reg_operand = Register(0).ToOperand();
-    BytecodeNode second(operator_replacement[0], reg_operand);
+    BytecodeNode second(operator_replacement[0], reg_operand, 1);
     second.source_info().Clone({4, true});
     optimizer()->Write(&first);
     optimizer()->Write(&second);
     CHECK_EQ(last_written(), first);
     Flush();
     CHECK_EQ(last_written(), second);
     Reset();
   }
 }
 
 TEST_F(BytecodePeepholeOptimizerTest, MergeLdaZeroWithBinaryOp) {
   Bytecode operator_replacement_pairs[][2] = {
       {Bytecode::kAdd, Bytecode::kAddSmi},
       {Bytecode::kSub, Bytecode::kSubSmi},
       {Bytecode::kBitwiseAnd, Bytecode::kBitwiseAndSmi},
       {Bytecode::kBitwiseOr, Bytecode::kBitwiseOrSmi},
       {Bytecode::kShiftLeft, Bytecode::kShiftLeftSmi},
       {Bytecode::kShiftRight, Bytecode::kShiftRightSmi}};
 
   for (auto operator_replacement : operator_replacement_pairs) {
     BytecodeNode first(Bytecode::kLdaZero);
     uint32_t reg_operand = Register(0).ToOperand();
-    BytecodeNode second(operator_replacement[0], reg_operand);
+    BytecodeNode second(operator_replacement[0], reg_operand, 1);
     optimizer()->Write(&first);
     optimizer()->Write(&second);
     Flush();
     CHECK_EQ(write_count(), 1);
     CHECK_EQ(last_written().bytecode(), operator_replacement[1]);
     CHECK_EQ(last_written().operand_count(), 2);
     CHECK_EQ(last_written().operand(0), 0);
     CHECK_EQ(last_written().operand(1), reg_operand);
     Reset();
   }
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8