[Interpreter] Assign feedback slots for binary operations and use them in ignition.

src/interpreter/bytecode-generator.cc

 // Copyright 2015 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/interpreter/bytecode-generator.h"
 
 #include "src/ast/scopes.h"
 #include "src/code-stubs.h"
 #include "src/compiler.h"
 #include "src/interpreter/bytecode-flags.h"
@@ skipping 2192 matching lines @@
         break;
       }
       case KEYED_SUPER_PROPERTY: {
         old_value = register_allocator()->NewRegister();
         BuildKeyedSuperPropertyLoad(object, home_object, key);
         builder()->StoreAccumulatorInRegister(old_value);
         break;
       }
     }
     VisitForAccumulatorValue(expr->value());
-    builder()->BinaryOperation(expr->binary_op(), old_value);
+    int feedback_slot_index =
+        feedback_index(expr->binary_operation()->BinaryOperationFeedbackSlot());

[rmcilroy, 2016/08/03 16:04:30]

nit - keep variable as "FeedbackVectorSlot slot" and just call
feedback_index(slot) when passing to BinaryOperation function

[mythria, 2016/08/05 07:08:15]

Done.

+    builder()->BinaryOperation(expr->binary_op(), old_value,
+                               feedback_slot_index);
   } else {
     VisitForAccumulatorValue(expr->value());
   }
 
   // Store the value.
   builder()->SetExpressionPosition(expr);
   FeedbackVectorSlot slot = expr->AssignmentSlot();
   switch (assign_type) {
     case VARIABLE: {
       // TODO(oth): The VisitVariableAssignment() call is hard to reason about.
@@ skipping 621 matching lines @@
 
   // Save result for postfix expressions.
   if (is_postfix) {
     old_value = register_allocator()->outer()->NewRegister();
 
     // Convert old value into a number before saving it.
     builder()->CastAccumulatorToNumber(old_value);
   }
 
   // Perform +1/-1 operation.
-  builder()->CountOperation(expr->binary_op());
+  int feedback_slot_index = feedback_index(expr->CountBinaryOpFeedbackSlot());

[rmcilroy, 2016/08/03 16:04:29]

ditto

[mythria, 2016/08/05 07:08:14]

Done.

+  builder()->CountOperation(expr->binary_op(), feedback_slot_index);
 
   // Store the value.
   builder()->SetExpressionPosition(expr);
   FeedbackVectorSlot feedback_slot = expr->CountSlot();
   switch (assign_type) {
     case VARIABLE: {
       Variable* variable = expr->expression()->AsVariableProxy()->var();
       VisitVariableAssignment(variable, expr->op(), feedback_slot);
       break;
     }
@@ skipping 50 matching lines @@
   builder()->SetExpressionPosition(expr);
   builder()->CompareOperation(expr->op(), lhs);
   execution_result()->SetResultInAccumulator();
 }
 
 void BytecodeGenerator::VisitArithmeticExpression(BinaryOperation* expr) {
   // TODO(rmcilroy): Special case "x * 1.0" and "x * -1" which are generated for
   // +x and -x by the parser.
   Register lhs = VisitForRegisterValue(expr->left());
   VisitForAccumulatorValue(expr->right());
-  builder()->BinaryOperation(expr->op(), lhs);
+  int feedback_slot_index = feedback_index(expr->BinaryOperationFeedbackSlot());

[rmcilroy, 2016/08/03 16:04:30]

ditto

[mythria, 2016/08/05 07:08:14]

Done.

+  builder()->BinaryOperation(expr->op(), lhs, feedback_slot_index);
   execution_result()->SetResultInAccumulator();
 }
 
 void BytecodeGenerator::VisitSpread(Spread* expr) { UNREACHABLE(); }
 
 void BytecodeGenerator::VisitEmptyParentheses(EmptyParentheses* expr) {
   UNREACHABLE();
 }
 
 void BytecodeGenerator::VisitThisFunction(ThisFunction* expr) {
@@ skipping 300 matching lines @@
   return execution_context()->scope()->language_mode();
 }
 
 int BytecodeGenerator::feedback_index(FeedbackVectorSlot slot) const {
   return TypeFeedbackVector::GetIndex(slot);
 }
 
 }  // namespace interpreter
 }  // namespace internal
 }  // namespace v8