tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py - Issue 220963003: [Telemetry] Output average GPU frequency from power metric

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py

Issue 220963003: [Telemetry] Output average GPU frequency from power metric (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: average_freq_mhz -> average_freq_hz Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/perf/metrics/power.py ('k') | tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py

diff --git a/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py b/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py

index 68c7b92ea73a75a87dc190453485c42ac3f6372e..f96deaf2d69ce15ee9f43542734ad5916997395a 100644

--- a/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py

+++ b/tools/telemetry/telemetry/core/platform/power_monitor/powermetrics_power_monitor.py

@@ -99,7 +99,7 @@ class PowerMetricsPowerMonitor(power_monitor.PowerMonitor):

# List of RunningAverage objects specifying metrics we want to aggregate.

metrics = [

ConstructMetric(

- ['component_utilization', 'whole_package', 'average_frequency_mhz'],

+ ['component_utilization', 'whole_package', 'average_frequency_hz'],

['processor','freq_hz']),

ConstructMetric(

['component_utilization', 'whole_package', 'idle_percent'],

@@ -140,7 +140,7 @@ class PowerMetricsPowerMonitor(power_monitor.PowerMonitor):

if 'GPU' in plist:

metrics.extend([

ConstructMetric(

- ['component_utilization', 'gpu', 'average_frequency_mhz'],

+ ['component_utilization', 'gpu', 'average_frequency_hz'],

['GPU', 0, 'freq_hz']),

ConstructMetric(

['component_utilization', 'gpu', 'idle_percent'],

@@ -162,7 +162,7 @@ class PowerMetricsPowerMonitor(power_monitor.PowerMonitor):

# C State ratio is per-package, component CPUs of that package may

# have different frequencies.

metrics.append(ConstructMetric(

- base_out_path + ['average_frequency_mhz'],

+ base_out_path + ['average_frequency_hz'],

base_src_path + ['cpus', cpu_idx, 'freq_hz']))

metrics.append(ConstructMetric(

base_out_path + ['idle_percent'],