Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1011)

Unified Diff: Source/devtools/front_end/TimelinePanel.js

Issue 220963002: DevTools: Add energy value under Timeline pie chart (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/TimelinePanel.js
diff --git a/Source/devtools/front_end/TimelinePanel.js b/Source/devtools/front_end/TimelinePanel.js
index 69e664aa5c0acb8feb9f3f6bc2e22f5b0aecf3ff..ded8ef15c5fd26241f23917f9ee7ff193b0055f7 100644
--- a/Source/devtools/front_end/TimelinePanel.js
+++ b/Source/devtools/front_end/TimelinePanel.js
@@ -890,8 +890,12 @@ WebInspector.TimelinePanel.prototype = {
aggregatedTotal += aggregatedStats[categoryName];
aggregatedStats["idle"] = Math.max(0, endTime - startTime - aggregatedTotal);
+ var energy = 0;
+ if (Capabilities.canProfilePower)
pfeldman 2014/04/11 12:17:49 This particular bit does not look modular. Eventua
Pan 2014/04/11 13:59:55 thanks, done
+ energy = this._viewsForMode(WebInspector.TimelinePanel.Mode.Power).overviewView.calculateEnergy(startTime, endTime);
+
var fragment = document.createDocumentFragment();
- fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(aggregatedStats));
+ fragment.appendChild(WebInspector.TimelineUIUtils.generatePieChart(aggregatedStats, undefined, undefined, energy));
pfeldman 2014/04/11 12:17:49 Lets append energy to the fragment instead - pie c
Pan 2014/04/11 13:59:55 How about append it after title? people will know
var startOffset = startTime - this._model.minimumRecordTime();
var endOffset = endTime - this._model.minimumRecordTime();
var title = WebInspector.UIString("%s \u2013 %s", Number.millisToString(startOffset), Number.millisToString(endOffset));
« no previous file with comments | « no previous file | Source/devtools/front_end/TimelinePowerOverview.js » ('j') | Source/devtools/front_end/TimelineUIUtils.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698