Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2209613002:
Remove WorkerEventQueue::EventDispatcherTask (Closed)
|
Created:
4 years, 4 months ago by tzik Modified:
4 years, 4 months ago CC:
chromium-reviews, blink-reviews, falken, kinuko+worker_chromium.org, blink-worker-reviews_chromium.org, horo+watch_chromium.org, yuryu Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove WorkerEventQueue::EventDispatcherTask
EventDispatcherTask is the last blocker of ExecutionContextTask removal.
It holds an Event and WorkerEventQueue instance, and makes the Event
cancellable.
This CL reimplements the cancellation mechanism without the custom
ExecutionContextTask and removes the custom one.
BUG=630139
Committed: https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16
Cr-Commit-Position: refs/heads/master@{#409732}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : update #
Total comments: 4
Patch Set 4 : -extra LF, -PtrUtil.h #
Messages
Total messages: 24 (18 generated)
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove WorkerEventQueue::EventDispatcherTask BUG= ========== to ========== Remove WorkerEventQueue::EventDispatcherTask BUG=630139 ==========
tzik@chromium.org changed reviewers: + hiroshige@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by tzik@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Remove WorkerEventQueue::EventDispatcherTask BUG=630139 ========== to ========== Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG=630139 ==========
tzik@chromium.org changed reviewers: + nhiroki@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with minor comments https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp (right): https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:30: #include "core/dom/ExecutionContextTask.h" Is this no longer necessary? https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:104: Can you remove this extra empty line.
https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp (right): https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:30: #include "core/dom/ExecutionContextTask.h" On 2016/08/04 02:08:39, nhiroki wrote: > Is this no longer necessary? It's still needed for createSameThreadTask(). https://codereview.chromium.org/2209613002/diff/40001/third_party/WebKit/Sour... third_party/WebKit/Source/core/workers/WorkerEventQueue.cpp:104: On 2016/08/04 02:08:39, nhiroki wrote: > Can you remove this extra empty line. Done.
The CQ bit was checked by tzik@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from nhiroki@chromium.org Link to the patchset: https://codereview.chromium.org/2209613002/#ps60001 (title: "-extra LF, -PtrUtil.h")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG=630139 ========== to ========== Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG=630139 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG=630139 ========== to ========== Remove WorkerEventQueue::EventDispatcherTask EventDispatcherTask is the last blocker of ExecutionContextTask removal. It holds an Event and WorkerEventQueue instance, and makes the Event cancellable. This CL reimplements the cancellation mechanism without the custom ExecutionContextTask and removes the custom one. BUG=630139 Committed: https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16 Cr-Commit-Position: refs/heads/master@{#409732} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/3697042db3e1ee433545c06bed5aee95657ebc16 Cr-Commit-Position: refs/heads/master@{#409732} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
