Add an SVG DM source

Add an SVG DM source

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004

Committed: https://skia.googlesource.com/skia/+/a2b9fdfe0b2dd3408064b7cfd1bf8677eaf06491

[f(malita), 2016-08-03 19:41:12]

Description was changed from

==========
SVG source support for DM

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
==========

to

==========
SVG source support for DM

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

[f(malita), 2016-08-03 19:45:57]

Description was changed from

==========
SVG source support for DM

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

to

==========
[DM] SVG source support

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

[f(malita), 2016-08-03 19:48:32]

Description was changed from

==========
[DM] SVG source support

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

to

==========
Add an SVG DM source

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

[f(malita), 2016-08-03 19:48:46]

The CQ bit was checked by fmalita@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 19:48:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 19:57:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 19:57:04]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-GN-Trybot on master.client.skia.compile
(JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[mtklein, 2016-08-03 21:40:26]

lgtm

https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp
File dm/DM.cpp (right):

https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp#newcode716
dm/DM.cpp:716: void gather_file_srcs(const SkCommandLineFlags::StringArray&
flags, const char* ext) {
Thank you for refactoring this.

[mtklein, 2016-08-03 21:45:02]

On 2016/08/03 21:40:26, mtklein wrote:
> lgtm
> 
> https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp
> File dm/DM.cpp (right):
> 
> https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp#newcode716
> dm/DM.cpp:716: void gather_file_srcs(const SkCommandLineFlags::StringArray&
> flags, const char* ext) {
> Thank you for refactoring this.

diff --git a/BUILD.gn b/BUILD.gn
index 3fae151..a6569bc 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -497,6 +497,27 @@ test_lib("bench") {
   ]
 }
 
+test_lib("experimental_svg_model") {
+  public_include_dirs = [ "experimental/svg/model" ]
+  sources = [
+    "experimental/svg/model/SkSVGAttribute.cpp",
+    "experimental/svg/model/SkSVGAttributeParser.cpp",
+    "experimental/svg/model/SkSVGContainer.cpp",
+    "experimental/svg/model/SkSVGDOM.cpp",
+    "experimental/svg/model/SkSVGNode.cpp",
+    "experimental/svg/model/SkSVGPath.cpp",
+    "experimental/svg/model/SkSVGRect.cpp",
+    "experimental/svg/model/SkSVGRenderContext.cpp",
+    "experimental/svg/model/SkSVGSVG.cpp",
+    "experimental/svg/model/SkSVGShape.cpp",
+    "experimental/svg/model/SkSVGTransformableNode.cpp",
+    "experimental/svg/model/SkSVGValue.cpp",
+  ]
+  deps = [
+    ":skia",
+  ]
+}
+
 if (!is_component_build) {  # Our test tools use many non-SK_API APIs...
   executable("dm") {
     sources = [
@@ -506,6 +527,7 @@ if (!is_component_build) {  # Our test tools use many
non-SK_API APIs...
     ]
     include_dirs = [ "tests" ]
     deps = [
+      ":experimental_svg_model",
       ":flags",
       ":gm",
       ":gpu_tool_utils",

[f(malita), 2016-08-04 02:17:57]

On 2016/08/03 21:45:02, mtklein wrote:
> On 2016/08/03 21:40:26, mtklein wrote:
> > lgtm
> > 
> > https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp
> > File dm/DM.cpp (right):
> > 
> > https://codereview.chromium.org/2209593004/diff/1/dm/DM.cpp#newcode716
> > dm/DM.cpp:716: void gather_file_srcs(const SkCommandLineFlags::StringArray&
> > flags, const char* ext) {
> > Thank you for refactoring this.
> 
> diff --git a/BUILD.gn b/BUILD.gn
> index 3fae151..a6569bc 100644
> --- a/BUILD.gn
> +++ b/BUILD.gn
> @@ -497,6 +497,27 @@ test_lib("bench") {
>    ]
>  }
>  
> +test_lib("experimental_svg_model") {
> +  public_include_dirs = [ "experimental/svg/model" ]
> +  sources = [
> +    "experimental/svg/model/SkSVGAttribute.cpp",
> +    "experimental/svg/model/SkSVGAttributeParser.cpp",
> +    "experimental/svg/model/SkSVGContainer.cpp",
> +    "experimental/svg/model/SkSVGDOM.cpp",
> +    "experimental/svg/model/SkSVGNode.cpp",
> +    "experimental/svg/model/SkSVGPath.cpp",
> +    "experimental/svg/model/SkSVGRect.cpp",
> +    "experimental/svg/model/SkSVGRenderContext.cpp",
> +    "experimental/svg/model/SkSVGSVG.cpp",
> +    "experimental/svg/model/SkSVGShape.cpp",
> +    "experimental/svg/model/SkSVGTransformableNode.cpp",
> +    "experimental/svg/model/SkSVGValue.cpp",
> +  ]
> +  deps = [
> +    ":skia",
> +  ]
> +}
> +
>  if (!is_component_build) {  # Our test tools use many non-SK_API APIs...
>    executable("dm") {
>      sources = [
> @@ -506,6 +527,7 @@ if (!is_component_build) {  # Our test tools use many
> non-SK_API APIs...
>      ]
>      include_dirs = [ "tests" ]
>      deps = [
> +      ":experimental_svg_model",
>        ":flags",
>        ":gm",
>        ":gpu_tool_utils",

Oh!  Thank you, I was just building up courage to look at GN :)

[f(malita), 2016-08-04 02:27:01]

The CQ bit was checked by fmalita@chromium.org

[f(malita), 2016-08-04 02:27:01]

The patchset sent to the CQ was uploaded after l-g-t-m from mtklein@google.com
Link to the patchset: https://codereview.chromium.org/2209593004/#ps20001
(title: "GN fix")

[commit-bot: I haz the power, 2016-08-04 02:27:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-04 02:53:46]

Description was changed from

==========
Add an SVG DM source

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004
==========

to

==========
Add an SVG DM source

R=mtklein@google.com,robertphillips@google.com,stephana@google.com
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209593004

Committed:
https://skia.googlesource.com/skia/+/a2b9fdfe0b2dd3408064b7cfd1bf8677eaf06491
==========

[commit-bot: I haz the power, 2016-08-04 02:53:47]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a2b9fdfe0b2dd3408064b7cfd1bf8677eaf06491