third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp - Issue 2209593002: Stop returning an empty handle from createWrapper()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

Issue 2209593002: Stop returning an empty handle from createWrapper() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/dom/create-element-after-stack-overflow.html ('K') | « third_party/WebKit/LayoutTests/fast/dom/create-element-after-stack-overflow-expected.txt ('k') | third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

index fe38dab0ee7101690f1bf3c75e80d06f08e5798b..67b1369eb11ddfa75a63bd77292d4653cf6f944e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/ScriptWrappable.cpp

@@ -24,9 +24,7 @@ v8::Local<v8::Object> ScriptWrappable::wrap(v8::Isolate* isolate, v8::Local<v8::

ASSERT(!DOMDataStore::containsWrapper(this, isolate));

v8::Local<v8::Object> wrapper = V8DOMWrapper::createWrapper(isolate, creationContext, wrapperTypeInfo);

- if (UNLIKELY(wrapper.IsEmpty()))

- return wrapper;

+ DCHECK(!wrapper.IsEmpty());

wrapperTypeInfo->installConditionallyEnabledProperties(wrapper, isolate);

return associateWithWrapper(isolate, wrapperTypeInfo, wrapper);

}