third_party/WebKit/LayoutTests/fast/dom/create-element-after-stack-overflow.html - Issue 2209593002: Stop returning an empty handle from createWrapper()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/dom/create-element-after-stack-overflow.html

Issue 2209593002: Stop returning an empty handle from createWrapper() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: temp Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« third_party/WebKit/LayoutTests/TestExpectations ('K') | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/dom/create-element-after-stack-overflow-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <head>	1 <head>

2 <script>	2 <script>

3 if (window.testRunner)	3 if (window.testRunner)

4 testRunner.dumpAsText();	4 testRunner.dumpAsText();

5	5

6 function test() {	6 function test() {

7 var e = document.createEvent("StorageEvent");	7 var e = document.createEvent("StorageEvent");

8 var target = document.getElementById("target");	8 var target = document.getElementById("target");

9 e.initEvent("beforecut", new Boolean(false), new Boolean(true));	9 e.initEvent("beforecut", new Boolean(false), new Boolean(true));

10 target.dispatchEvent(e);	10 target.dispatchEvent(e);

11 document.createElement("marquee");	11 document.createElement("div");
haraken 2016/08/04 04:40:28 This test starts crashing after this CL, but I not This test starts crashing after this CL, but I noticed that it's a very specific issue to <marquee>. Since <marquee> is implemented by Blink-in-JS, createElement("marquee") crashes when calling a JS function and hitting the kRecursionMaxDepth check in V8ScriptRunner.cpp. That might be problematic, but either way this test is not intending to test Blink-in-JS under stack-overflow. So I changed <marquee> to <div>.
12 }	12 }

13 </script>	13 </script>

14 </head>	14 </head>

15 <menu onbeforecut=test()>	15 <menu onbeforecut=test()>

16 <div id="target"></div><style onload=test()></style>	16 <div id="target"></div><style onload=test()></style>

17 </menu>	17 </menu>

18 <div>Pass when no crash observed.</div>	18 <div>Pass when no crash observed.</div>

OLD	NEW