src/parsing/pattern-rewriter.cc - Issue 2209573002: Separate Scope into DeclarationScope and Scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/pattern-rewriter.cc

Issue 2209573002: Separate Scope into DeclarationScope and Scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed adamks comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/pattern-rewriter.cc

diff --git a/src/parsing/pattern-rewriter.cc b/src/parsing/pattern-rewriter.cc

index e00403135a18dc4d0309a00589fb8b8001150c4e..30d521dfa76c47616cbdaf9ecf89399881263795 100644

--- a/src/parsing/pattern-rewriter.cc

+++ b/src/parsing/pattern-rewriter.cc

@@ -163,7 +163,7 @@ void Parser::PatternRewriter::VisitVariableProxy(VariableProxy* pattern) {

Scope* declaration_scope = IsLexicalVariableMode(descriptor_->mode)

? descriptor_->scope

- : descriptor_->scope->DeclarationScope();

+ : descriptor_->scope->GetDeclarationScope();

if (declaration_scope->num_var() > kMaxNumFunctionLocals) {

parser_->ReportMessage(MessageTemplate::kTooManyVariables);

*ok_ = false;