src/parsing/parameter-initializer-rewriter.cc - Issue 2209573002: Separate Scope into DeclarationScope and Scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parsing/parameter-initializer-rewriter.cc

Issue 2209573002: Separate Scope into DeclarationScope and Scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed adamks comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parsing/parameter-initializer-rewriter.cc

diff --git a/src/parsing/parameter-initializer-rewriter.cc b/src/parsing/parameter-initializer-rewriter.cc

index f59b0fb368f9166b744d31d53762430e8df0839f..b12a80f9b8d83dffb7bae2223a7d5c465ca576ca 100644

--- a/src/parsing/parameter-initializer-rewriter.cc

+++ b/src/parsing/parameter-initializer-rewriter.cc

@@ -68,7 +68,7 @@ void Rewriter::VisitVariableProxy(VariableProxy* proxy) {

} else {

// Ensure that temporaries we find are already in the correct scope.

DCHECK(proxy->var()->mode() != TEMPORARY ||

- proxy->var()->scope() == param_scope_->ClosureScope());

+ proxy->var()->scope() == param_scope_->GetClosureScope());

}