src/ast/ast-numbering.cc - Issue 2209573002: Separate Scope into DeclarationScope and Scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast-numbering.cc

Issue 2209573002: Separate Scope into DeclarationScope and Scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast-numbering.cc

diff --git a/src/ast/ast-numbering.cc b/src/ast/ast-numbering.cc

index 0dd6f1d5dabacfaa57fbf33007a96771ef3a87d8..b3b163a138594d35739ea2ae40e199ab0aaea9a0 100644

--- a/src/ast/ast-numbering.cc

+++ b/src/ast/ast-numbering.cc

@@ -559,7 +559,7 @@ void AstNumberingVisitor::VisitRewritableExpression(

bool AstNumberingVisitor::Renumber(FunctionLiteral* node) {

- Scope* scope = node->scope();

+ DeclarationScope* scope = node->scope();

if (scope->new_target_var()) DisableCrankshaft(kSuperReference);

if (scope->calls_eval()) DisableOptimization(kFunctionCallsEval);

if (scope->arguments() != NULL && !scope->arguments()->IsStackAllocated()) {