src/asmjs/asm-wasm-builder.cc - Issue 2209573002: Separate Scope into DeclarationScope and Scope

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/asmjs/asm-wasm-builder.cc

Issue 2209573002: Separate Scope into DeclarationScope and Scope (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Cleanup diff Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/asmjs/asm-wasm-builder.cc

diff --git a/src/asmjs/asm-wasm-builder.cc b/src/asmjs/asm-wasm-builder.cc

index 9ac748bdd0f4b553327ecbe0c32855372b45cc68..db9fe69a7d5aedb354cdf0c1e0675d75fd622634 100644

--- a/src/asmjs/asm-wasm-builder.cc

+++ b/src/asmjs/asm-wasm-builder.cc

@@ -443,7 +443,7 @@ class AsmWasmBuilderImpl final : public AstVisitor<AsmWasmBuilderImpl> {

void VisitDebuggerStatement(DebuggerStatement* stmt) { UNREACHABLE(); }

void VisitFunctionLiteral(FunctionLiteral* expr) {

- Scope* scope = expr->scope();

+ DeclarationScope* scope = expr->scope();

if (scope_ == kFuncScope) {

if (auto* func_type = typer_->TypeOf(expr)->AsFunctionType()) {

// Build the signature for the function.