Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2209563002: Subzero: removed loops from ASan access checking (Closed)

Created:
4 years, 4 months ago by tlively
Modified:
4 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero: removed loops from ASan access checking BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=7a934724a8bb318f8bbc61c7e9cc102101290b5c

Patch Set 1 #

Patch Set 2 : Removed incorrect assertion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M runtime/szrt_asan.c View 1 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
tlively
This CL improves the average slowdown over spec2k tests by 40%, from 8.8x to 5.3x.
4 years, 4 months ago (2016-08-03 03:25:43 UTC) #2
Karl
lgtm Nice.
4 years, 4 months ago (2016-08-03 17:38:06 UTC) #3
tlively
4 years, 4 months ago (2016-08-03 18:15:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
7a934724a8bb318f8bbc61c7e9cc102101290b5c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698