Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209533004: spin off easy stuff from Herb's windows GN CL (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
herb_g, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

spin off easy stuff from Herb's windows GN CL BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209533004 No public API changes. TBR=reed@google.com Committed: https://skia.googlesource.com/skia/+/7a1f45f9e584fef625e764bd5d180a9c4943dcd5

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -6 lines) Patch
M BUILD.gn View 1 3 chunks +5 lines, -1 line 0 comments Download
M gm/circles.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/ovals.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/rects.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/roundrects.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/shadows.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gm/tilemodes.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M gm/tilemodes_scaled.cpp View 1 chunk +2 lines, -1 line 0 comments Download
A + gn/win_stamp.py View 1 chunk +5 lines, -0 lines 0 comments Download
M include/c/sk_types.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkPreConfig.h View 1 chunk +1 line, -1 line 0 comments Download
M tests/BlurTest.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/expat/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M third_party/giflib/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/libjpeg_turbo/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
mtklein_C
Note the small changes to sk_types/SkPreConfig and win_stamp.py. I also ran gn format.
4 years, 4 months ago (2016-08-03 21:09:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209533004/20001
4 years, 4 months ago (2016-08-03 21:21:49 UTC) #8
herb_g
lgtm
4 years, 4 months ago (2016-08-04 13:18:07 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209533004/20001
4 years, 4 months ago (2016-08-04 13:18:22 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 13:19:39 UTC) #18
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7a1f45f9e584fef625e764bd5d180a9c4943dcd5

Powered by Google App Engine
This is Rietveld 408576698