Issue 2209483002: Update pdfium/annots/annotation_underline_expected.pdf.0.png with actual underline annotation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2209483002: Update pdfium/annots/annotation_underline_expected.pdf.0.png with actual underline annotation. (Closed)

Created:
4 years, 4 months ago by jaepark

Modified:
4 years, 4 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com, dsinclair

Base URL:
https://pdfium.googlesource.com/pdfium_tests@master

Target Ref:
refs/heads/master

Visibility:
Public.

Update pdfium/annots/annotation_underline_expected.pdf.0.png with actual underline annotation. Also, add a test case for underline annotation with opacity. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium_tests/+/cae29d1e4ac7a9c32add1a6ac0d04d60298a278e

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -0 lines)		Patch
M	pdfium/annots/annotation_underline_expected.pdf.0.png	View	Binary file	0 comments	Download
A +	pdfium/annots/annotation_underline_opacity.pdf	View	Binary file	0 comments	Download
A +	pdfium/annots/annotation_underline_opacity_expected.pdf.0.png	View	Binary file	0 comments	Download

Total messages: 5 (2 generated)

jaepark

This is an updated test result + an additional test case for underline annotation (https://codereview.chromium.org/2205543002/).

4 years, 4 months ago (2016-08-02 22:45:10 UTC) #2

jaepark

4 years, 4 months ago (2016-08-02 22:48:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
cae29d1e4ac7a9c32add1a6ac0d04d60298a278e (presubmit successful).