Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2209443005: [Mac] Refactor for updating the download item (Closed)

Created:
4 years, 4 months ago by spqchan
Modified:
4 years, 4 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, asanka, dbeam+watch-downloads_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Mac] Refactor for updating the download item BUG=600411 Committed: https://crrev.com/5a4f7e7641eef740f46465d0cdf212285445cab4 Cr-Commit-Position: refs/heads/master@{#410431}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M chrome/browser/ui/cocoa/download/download_item_controller.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_item_controller.mm View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/download/download_shelf_controller.mm View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
spqchan
PTAL Thanks for letting me know about this, it works :)
4 years, 4 months ago (2016-08-04 02:56:42 UTC) #2
Robert Sesek
On 2016/08/04 02:56:42, spqchan (OOO until Aug 8) wrote: > PTAL > > Thanks for ...
4 years, 4 months ago (2016-08-04 14:45:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209443005/1
4 years, 4 months ago (2016-08-08 18:23:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-08 20:23:57 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-08 20:26:03 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a4f7e7641eef740f46465d0cdf212285445cab4
Cr-Commit-Position: refs/heads/master@{#410431}

Powered by Google App Engine
This is Rietveld 408576698