Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Issue 2209443003: [Telemetry] Rename webpagereplay to wpr_server (Closed)

Created:
4 years, 4 months ago by nednguyen
Modified:
4 years, 4 months ago
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[Telemetry] Rename webpagereplay to wpr_server This is to prepare for adding ts_proxy_server. Renaming makes it clearer what the role of this package is about & consistent with ts_proxy_server's naming. BUG=catapult:#2584 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/efec1f2e771b4143a39c667f26c819f25b6f2a4a

Patch Set 1 #

Patch Set 2 : Update mock reference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -406 lines) Patch
M telemetry/telemetry/internal/platform/network_controller_backend.py View 2 chunks +2 lines, -2 lines 0 comments Download
M telemetry/telemetry/internal/platform/network_controller_backend_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
D telemetry/telemetry/internal/util/webpagereplay.py View 1 chunk +0 lines, -329 lines 0 comments Download
D telemetry/telemetry/internal/util/webpagereplay_unittest.py View 1 chunk +0 lines, -68 lines 0 comments Download
A + telemetry/telemetry/internal/util/wp_server_unittest.py View 7 chunks +7 lines, -7 lines 0 comments Download
A + telemetry/telemetry/internal/util/wpr_server.py View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
nednguyen
4 years, 4 months ago (2016-08-02 20:55:26 UTC) #3
petrcermak
LGTM with a nit: You're missing a period at the end of the description (after ...
4 years, 4 months ago (2016-08-03 08:55:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209443003/20001
4 years, 4 months ago (2016-08-03 10:12:36 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 10:14:13 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698