Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Unified Diff: src/wasm/ast-decoder.cc

Issue 2209433002: [wasm] Make LoadGlobal/StoreGlobal opcodes match what is coming in binary 0xC. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/wasm-interpreter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/wasm/ast-decoder.cc
diff --git a/src/wasm/ast-decoder.cc b/src/wasm/ast-decoder.cc
index f686f6c02efa2cab91cd8f801beccec73aec1f98..d797120274a49d9940ffa18973891e1027157ad5 100644
--- a/src/wasm/ast-decoder.cc
+++ b/src/wasm/ast-decoder.cc
@@ -256,7 +256,7 @@ class WasmDecoder : public Decoder {
case kExprF64Const:
case kExprF32Const:
case kExprGetLocal:
- case kExprLoadGlobal:
+ case kExprGetGlobal:
case kExprNop:
case kExprUnreachable:
case kExprEnd:
@@ -264,7 +264,7 @@ class WasmDecoder : public Decoder {
case kExprLoop:
return 0;
- case kExprStoreGlobal:
+ case kExprSetGlobal:
case kExprSetLocal:
case kExprElse:
return 1;
@@ -339,8 +339,8 @@ class WasmDecoder : public Decoder {
BreakDepthOperand operand(this, pc);
return 1 + operand.length;
}
- case kExprStoreGlobal:
- case kExprLoadGlobal: {
+ case kExprSetGlobal:
+ case kExprGetGlobal: {
GlobalIndexOperand operand(this, pc);
return 1 + operand.length;
}
@@ -891,19 +891,19 @@ class WasmFullDecoder : public WasmDecoder {
len = 1 + operand.length;
break;
}
- case kExprLoadGlobal: {
+ case kExprGetGlobal: {
GlobalIndexOperand operand(this, pc_);
if (Validate(pc_, operand)) {
- Push(operand.type, BUILD(LoadGlobal, operand.index));
+ Push(operand.type, BUILD(GetGlobal, operand.index));
}
len = 1 + operand.length;
break;
}
- case kExprStoreGlobal: {
+ case kExprSetGlobal: {
GlobalIndexOperand operand(this, pc_);
if (Validate(pc_, operand)) {
Value val = Pop(0, operand.type);
- BUILD(StoreGlobal, operand.index, val.node);
+ BUILD(SetGlobal, operand.index, val.node);
Push(val.type, val.node);
}
len = 1 + operand.length;
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/wasm/wasm-interpreter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698