Use invalidation sets for :hover, :active, and :focus.

Source/core/css/AffectedByFocusTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "HTMLNames.h"
 #include "core/dom/Element.h"
 #include "core/dom/ElementTraversal.h"
 #include "core/dom/NodeRenderStyle.h"
 #include "core/frame/FrameView.h"
@@ skipping 232 matching lines @@
     unsigned startCount = document().styleEngine()->resolverAccessCount();
 
     document().getElementById("d")->focus();
     document().view()->updateLayoutAndStyleIfNeededRecursive();
 
     unsigned accessCount = document().styleEngine()->resolverAccessCount() - startCount;
 
     ASSERT_EQ(11U, accessCount);
 }
 
+TEST_F(AffectedByFocusTest, InvalidationSetFocusUpdate)
+{
+    // Check that when focussing the outer div in the document below, you get a
+    // style recalc for the outer div and the class=a div only.
+
+    setHtmlInnerHTML("<style>:focus .a { border: 1px solid lime; }</style>"
+        "<div id=d tabIndex=1>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div class='a'></div>"
+        "</div>");
+
+    document().view()->updateLayoutAndStyleIfNeededRecursive();
+
+    unsigned startCount = document().styleEngine()->resolverAccessCount();
+
+    document().getElementById("d")->focus();
+    document().view()->updateLayoutAndStyleIfNeededRecursive();
+
+    unsigned accessCount = document().styleEngine()->resolverAccessCount() - startCount;
+
+    ASSERT_EQ(2U, accessCount);
+}
+
+TEST_F(AffectedByFocusTest, NoInvalidationSetFocusUpdate)
+{
+    // Check that when focussing the outer div in the document below, you get a
+    // style recalc for the outer div only. The invalidation set for :focus will
+    // include 'a', but the id=d div should be affectedByFocus, not childrenAffectedByFocus.
+
+    setHtmlInnerHTML("<style>#nomatch:focus .a { border: 1px solid lime; }</style>"
+        "<div id=d tabIndex=1>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"

[esprehn, 2014/04/04 22:48:27]

Can we just write the normal layout tests like we've been doing for this
feature? I'd rather not have the tests in so many places.

[rune, 2014/04/10 12:42:12]

Style update for focus still happens synchronously for some reason. I haven't
looked into that. Do you want me to remove this?

+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div></div>"
+        "<div class='a'></div>"
+        "</div>");
+
+    document().view()->updateLayoutAndStyleIfNeededRecursive();
+
+    unsigned startCount = document().styleEngine()->resolverAccessCount();
+
+    document().getElementById("d")->focus();
+    document().view()->updateLayoutAndStyleIfNeededRecursive();
+
+    unsigned accessCount = document().styleEngine()->resolverAccessCount() - startCount;
+
+    ASSERT_EQ(1U, accessCount);
+}
+
 } // namespace