OLD | NEW |
---|---|
1 # Copyright 2016 The Chromium Authors. All rights reserved. | 1 # Copyright 2016 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 | 5 |
6 # pylint: disable=W0201 | 6 # pylint: disable=W0201 |
7 | 7 |
8 | 8 |
9 from recipe_engine import recipe_api | 9 from recipe_engine import recipe_api |
10 | 10 |
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
82 return coverage_flavor.CoverageFlavorUtils(self.m) | 82 return coverage_flavor.CoverageFlavorUtils(self.m) |
83 else: | 83 else: |
84 return default_flavor.DefaultFlavorUtils(self.m) | 84 return default_flavor.DefaultFlavorUtils(self.m) |
85 | 85 |
86 def setup(self): | 86 def setup(self): |
87 self._f = self.get_flavor(self.m.vars.builder_cfg) | 87 self._f = self.get_flavor(self.m.vars.builder_cfg) |
88 | 88 |
89 def step(self, name, cmd, **kwargs): | 89 def step(self, name, cmd, **kwargs): |
90 return self._f.step(name, cmd, **kwargs) | 90 return self._f.step(name, cmd, **kwargs) |
91 | 91 |
92 def compile(self, target): | 92 def compile(self, target, **kwargs): |
rmistry
2016/08/04 20:02:58
Why not have compile explicitly take in an env par
borenet
2016/08/05 11:41:05
It seemed easier to provide plumbing for arbitrary
rmistry
2016/08/05 11:45:04
No, leaving it up to you. My thinking was that it
| |
93 return self._f.compile(target) | 93 return self._f.compile(target, **kwargs) |
94 | 94 |
95 def copy_extra_build_products(self, swarming_out_dir): | 95 def copy_extra_build_products(self, swarming_out_dir): |
96 return self._f.copy_extra_build_products(swarming_out_dir) | 96 return self._f.copy_extra_build_products(swarming_out_dir) |
97 | 97 |
98 @property | 98 @property |
99 def out_dir(self): | 99 def out_dir(self): |
100 return self._f.out_dir | 100 return self._f.out_dir |
101 | 101 |
102 def device_path_join(self, *args): | 102 def device_path_join(self, *args): |
103 return self._f.device_path_join(*args) | 103 return self._f.device_path_join(*args) |
(...skipping 103 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
207 version, | 207 version, |
208 VERSION_FILE_SKP, | 208 VERSION_FILE_SKP, |
209 self.m.vars.tmp_dir, | 209 self.m.vars.tmp_dir, |
210 self.m.vars.local_skp_dir, | 210 self.m.vars.local_skp_dir, |
211 self.device_dirs.skp_dir, | 211 self.device_dirs.skp_dir, |
212 test_expected_version=self.m.properties.get( | 212 test_expected_version=self.m.properties.get( |
213 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION), | 213 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION), |
214 test_actual_version=self.m.properties.get( | 214 test_actual_version=self.m.properties.get( |
215 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION)) | 215 'test_downloaded_skp_version', TEST_EXPECTED_SKP_VERSION)) |
216 return version | 216 return version |
OLD | NEW |