Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: ui/base/resource/resource_bundle.h

Issue 2209363002: Remove material design resource pak infrastructure (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove another mac test file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/base/resource/data_pack.cc ('k') | ui/base/resource/resource_bundle.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/base/resource/resource_bundle.h
diff --git a/ui/base/resource/resource_bundle.h b/ui/base/resource/resource_bundle.h
index 29584f694dd8ea235f7997f8d3234428cb513a52..dea3b8f31be697a9458ea60532a4b457ca26b073 100644
--- a/ui/base/resource/resource_bundle.h
+++ b/ui/base/resource/resource_bundle.h
@@ -179,15 +179,6 @@ class UI_BASE_EXPORT ResourceBundle {
void AddOptionalDataPackFromPath(const base::FilePath& path,
ScaleFactor scale_factor);
- // The same as AddDataPackFromPath() and AddOptionalDataPackFromPath(),
- // except the data pack is flagged as containing only material design assets.
- // TODO(tdanderson): These methods are temporary and should be removed after
- // the transition to material design in the browser UI.
- void AddMaterialDesignDataPackFromPath(const base::FilePath& path,
- ScaleFactor scale_factor);
- void AddOptionalMaterialDesignDataPackFromPath(const base::FilePath& path,
- ScaleFactor scale_factor);
-
// Changes the locale for an already-initialized ResourceBundle, returning the
// name of the newly-loaded locale. Future calls to get strings will return
// the strings for this new locale. This has no effect on existing or future
@@ -289,12 +280,6 @@ class UI_BASE_EXPORT ResourceBundle {
// Returns SCALE_FACTOR_100P if no resource is loaded.
ScaleFactor GetMaxScaleFactor() const;
-#if defined(OS_MACOSX)
- // Loads Material Design data packs and makes them the first items in
- // |data_packs_|.
- void LoadMaterialDesignResources();
-#endif
-
// Returns true if |scale_factor| is supported by this platform.
static bool IsScaleFactorSupported(ScaleFactor scale_factor);
@@ -302,12 +287,6 @@ class UI_BASE_EXPORT ResourceBundle {
FRIEND_TEST_ALL_PREFIXES(ResourceBundleTest, DelegateGetPathForLocalePack);
FRIEND_TEST_ALL_PREFIXES(ResourceBundleTest, DelegateGetImageNamed);
FRIEND_TEST_ALL_PREFIXES(ResourceBundleTest, DelegateGetNativeImageNamed);
- FRIEND_TEST_ALL_PREFIXES(ResourceBundleImageTest,
- CountMaterialDesignDataPacksInResourceBundle);
- FRIEND_TEST_ALL_PREFIXES(ResourceBundleMacImageTest,
- CheckImageFromMaterialDesign);
- FRIEND_TEST_ALL_PREFIXES(ChromeBrowserMainMacBrowserTest,
- MDResourceAccess);
friend class ResourceBundleMacImageTest;
friend class ResourceBundleImageTest;
@@ -334,19 +313,14 @@ class UI_BASE_EXPORT ResourceBundle {
// Load the main resources.
void LoadCommonResources();
- // Loads the resource paks chrome_{100,200}_percent.pak. Also loads the
- // resource paks chrome_material_{100,200}_percent.pak contaning top
- // chrome material design assets if the runtime flag is enabled.
+ // Loads the resource paks chrome_{100,200}_percent.pak.
void LoadChromeResources();
// Implementation for the public methods which add a DataPack from a path. If
- // |optional| is false, an error is logged on failure to load. Sets the
- // member |has_only_material_design_assets_| on the created DataPack to the
- // value of |has_only_material_assets|.
+ // |optional| is false, an error is logged on failure to load.
void AddDataPackFromPathInternal(const base::FilePath& path,
ScaleFactor scale_factor,
- bool optional,
- bool has_only_material_assets);
+ bool optional);
// Inserts |data_pack| to |data_pack_| and updates |max_scale_factor_|
// accordingly.
« no previous file with comments | « ui/base/resource/data_pack.cc ('k') | ui/base/resource/resource_bundle.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698