Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2209333004: Add serialization capabilities to PwsResult (Closed)

Created:
4 years, 4 months ago by cco3
Modified:
4 years, 4 months ago
Reviewers:
gone, mattreynolds
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add serialization capabilities to PwsResult This will let us store PwsResults along with UrlInfos in the UrlManager, giving us more opportunities to compare the two together and shift the burden away form the ListUrlsActivity. BUG=633715 Committed: https://crrev.com/218aec3aa9e6174071660db1f593d87dd7151a27 Cr-Commit-Position: refs/heads/master@{#409911}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -10 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsClientImpl.java View 1 chunk +1 line, -10 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java View 3 chunks +43 lines, -0 lines 1 comment Download
A chrome/android/javatests/src/org/chromium/chrome/browser/physicalweb/PwsResultTest.java View 1 chunk +58 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
cco3
4 years, 4 months ago (2016-08-04 20:49:00 UTC) #2
mattreynolds
lgtm
4 years, 4 months ago (2016-08-04 21:21:38 UTC) #3
cco3
4 years, 4 months ago (2016-08-04 21:22:07 UTC) #5
gone
lgtm https://codereview.chromium.org/2209333004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java File chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java (right): https://codereview.chromium.org/2209333004/diff/1/chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java#newcode99 chrome/android/java/src/org/chromium/chrome/browser/physicalweb/PwsResult.java:99: .put(GROUP_ID_KEY, groupId)); nit: Might be nicer if you ...
4 years, 4 months ago (2016-08-04 21:31:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209333004/1
4 years, 4 months ago (2016-08-04 21:34:42 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-04 22:15:47 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 22:17:14 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/218aec3aa9e6174071660db1f593d87dd7151a27
Cr-Commit-Position: refs/heads/master@{#409911}

Powered by Google App Engine
This is Rietveld 408576698