Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2209313002: [gn] Switch tsan to gn (Closed)

Created:
4 years, 4 months ago by Michael Achenbach
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[gn] Switch tsan to gn BUG=chromium:474921 NOTRY=true Committed: https://crrev.com/e866b969bf1a8a711f3f241765bbec539e37fceb Cr-Commit-Position: refs/heads/master@{#38374}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M infra/mb/mb_config.pyl View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Michael Achenbach
PTAL. Split off CL https://codereview.chromium.org/2188693002/#ps100001 as underlying test errors should be fixed. Comparison link: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11029/steps/compare%20build%20flags%20%28fyi%29/logs/stdio
4 years, 4 months ago (2016-08-04 14:34:59 UTC) #3
jochen (gone - plz use gerrit)
lgtm
4 years, 4 months ago (2016-08-05 11:38:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209313002/1
4 years, 4 months ago (2016-08-05 11:48:06 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-05 11:52:32 UTC) #8
commit-bot: I haz the power
4 years, 4 months ago (2016-08-05 11:55:28 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e866b969bf1a8a711f3f241765bbec539e37fceb
Cr-Commit-Position: refs/heads/master@{#38374}

Powered by Google App Engine
This is Rietveld 408576698