make SpecialLineRec::addSegment assert more permissive to accomodate rounding error

make SpecialLineRec::addSegment assert more permissive to accomodate rounding error

Because the driving code that calls SpecialLineRec::addSegment uses double precision,
when converted back to single precision this may round such that d0 and d1 are the same.
This causes the assert to trigger. The simplest thing to do here is to modify the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209303004

Committed: https://skia.googlesource.com/skia/+/0adbd3e0a61c039fea1d47c006daa462bae42318

[lsalzman1, 2016-08-04 17:08:13]

Description was changed from

==========
make SpecialLineRec::addSegment assert more permissive to accomodate rounding
error

Because the driving code that calls SpecialLineRec::addSegment uses double
precision,
when converted back to single precision this may round such that d0 and d1 are
the same.
This causes the assert to trigger. The simplest thing to do here is to modify
the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
==========

to

==========
make SpecialLineRec::addSegment assert more permissive to accomodate rounding
error

Because the driving code that calls SpecialLineRec::addSegment uses double
precision,
when converted back to single precision this may round such that d0 and d1 are
the same.
This causes the assert to trigger. The simplest thing to do here is to modify
the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209303004
==========

[lsalzman1, 2016-08-04 17:09:06]

lsalzman@mozilla.com changed reviewers:
+ caryclark@google.com

[caryclark, 2016-08-08 19:56:42]

On 2016/08/04 17:09:07, lsalzman1 wrote:

My apologies for not getting to this sooner. I was on vacation last week. I'm
reviewing now

[caryclark, 2016-08-08 20:05:56]

lgtm

[lsalzman1, 2016-08-08 20:09:43]

The CQ bit was checked by lsalzman@mozilla.com

[commit-bot: I haz the power, 2016-08-08 20:09:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-08 20:40:30]

Description was changed from

==========
make SpecialLineRec::addSegment assert more permissive to accomodate rounding
error

Because the driving code that calls SpecialLineRec::addSegment uses double
precision,
when converted back to single precision this may round such that d0 and d1 are
the same.
This causes the assert to trigger. The simplest thing to do here is to modify
the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209303004
==========

to

==========
make SpecialLineRec::addSegment assert more permissive to accomodate rounding
error

Because the driving code that calls SpecialLineRec::addSegment uses double
precision,
when converted back to single precision this may round such that d0 and d1 are
the same.
This causes the assert to trigger. The simplest thing to do here is to modify
the assert
to not be so picky and allow the rare/occasional equality.

Downstream Firefox bug report:
https://bugzilla.mozilla.org/show_bug.cgi?id=1290628

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2209303004

Committed:
https://skia.googlesource.com/skia/+/0adbd3e0a61c039fea1d47c006daa462bae42318
==========

[commit-bot: I haz the power, 2016-08-08 20:40:31]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0adbd3e0a61c039fea1d47c006daa462bae42318