Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h

Issue 2209303002: binding: Moves the check for the first access to the initial document into BindingSecurity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
diff --git a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
index 153818bbed68b452a466f2d3a9340a7fea805d75..b0746e17f5a9dbe4dac2a1954186ae8748baf005 100644
--- a/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
+++ b/third_party/WebKit/Source/bindings/core/v8/BindingSecurity.h
@@ -52,6 +52,9 @@ enum SecurityReportingOption {
ReportSecurityError,
};
+// TODO(yukishiino): Remove the first argument of v8::Isolate*. These functions
+// just check if it's accessible or not, and never create anything. So there is
+// no need to pass the isolate.
class CORE_EXPORT BindingSecurity {
STATIC_ONLY(BindingSecurity);
public:
« no previous file with comments | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | third_party/WebKit/Source/bindings/core/v8/BindingSecurity.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698