chrome/browser/apps/app_browsertest.cc - Issue 2209303002: binding: Moves the check for the first access to the initial document into BindingSecurity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/apps/app_browsertest.cc

Issue 2209303002: binding: Moves the check for the first access to the initial document into BindingSecurity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed review comments. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java ('k') | chrome/browser/ssl/ssl_browser_tests.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/apps/app_browsertest.cc

diff --git a/chrome/browser/apps/app_browsertest.cc b/chrome/browser/apps/app_browsertest.cc

index 7300ae4ace0c8a077c36291af02d16b7045ecc1f..f513a78c69cd9e6dd53a369702e8bda787b8b4e5 100644

--- a/chrome/browser/apps/app_browsertest.cc

+++ b/chrome/browser/apps/app_browsertest.cc

@@ -41,6 +41,7 @@

#include "content/public/browser/host_zoom_map.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/render_widget_host_view.h"

+#include "content/public/test/browser_test_utils.h"

#include "content/public/test/test_utils.h"

#include "extensions/browser/app_window/app_window.h"

#include "extensions/browser/app_window/app_window_registry.h"

@@ -451,8 +452,10 @@ IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest,

message_;

observer.Wait();

ASSERT_EQ(kExpectedNumberOfTabs, observer.tabs().size());

+ content::WaitForLoadStop(observer.tabs()[kExpectedNumberOfTabs - 1]);

EXPECT_EQ(GURL(kChromiumURL),

observer.tabs()[kExpectedNumberOfTabs - 1]->GetURL());

+ content::WaitForLoadStop(observer.tabs()[kExpectedNumberOfTabs - 2]);

EXPECT_EQ(GURL(kChromiumURL),

observer.tabs()[kExpectedNumberOfTabs - 2]->GetURL());

}