Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1203)

Unified Diff: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java

Issue 2209303002: binding: Moves the check for the first access to the initial document into BindingSecurity. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
diff --git a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
index f14ba481ec0a694068d6e4695e61d8ccf353d578..cb4e8b096da8030cb36537f2486c02501c585455 100644
--- a/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
+++ b/android_webview/javatests/src/org/chromium/android_webview/test/AwTestBase.java
@@ -659,8 +659,15 @@ public class AwTestBase
});
OnPageFinishedHelper onPageFinishedHelper = popupContentsClient.getOnPageFinishedHelper();
- int callCount = onPageFinishedHelper.getCallCount();
- onPageFinishedHelper.waitForCallback(callCount, 1, WAIT_TIMEOUT_MS, TimeUnit.MILLISECONDS);
+ int finishCallCount = onPageFinishedHelper.getCallCount();
+ TestAwContentsClient.OnReceivedTitleHelper onReceivedTitleHelper =
+ popupContentsClient.getOnReceivedTitleHelper();
+ int titleCallCount = onReceivedTitleHelper.getCallCount();
+
+ onPageFinishedHelper.waitForCallback(finishCallCount, 1, WAIT_TIMEOUT_MS,
+ TimeUnit.MILLISECONDS);
+ onReceivedTitleHelper.waitForCallback(titleCallCount, 1, WAIT_TIMEOUT_MS,
+ TimeUnit.MILLISECONDS);
return new PopupInfo(popupContentsClient, popupContainerView, popupContents);
}
« no previous file with comments | « no previous file | android_webview/javatests/src/org/chromium/android_webview/test/PopupWindowTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698