binding: Moves the check for the first access to the initial document into BindingSecurity.

third_party/WebKit/Source/bindings/templates/interface_base.cpp

Index: third_party/WebKit/Source/bindings/templates/interface_base.cpp
diff --git a/third_party/WebKit/Source/bindings/templates/interface_base.cpp b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
index 1ea037fe52ae7869108177bcca360bbdd6bb7cd7..e4fe0cd7522eec3b1667862f126d4967b6d6b6d7 100644
--- a/third_party/WebKit/Source/bindings/templates/interface_base.cpp
+++ b/third_party/WebKit/Source/bindings/templates/interface_base.cpp
@@ -88,19 +88,7 @@ bool securityCheck(v8::Local<v8::Context> accessingContext, v8::Local<v8::Object
     if (window.IsEmpty())
         return false; // the frame is gone.
 
-    DOMWindow* targetWindow = V8Window::toImpl(window);
-    ASSERT(targetWindow);
-    if (!targetWindow->isLocalDOMWindow())
-        return false;
-
-    LocalFrame* targetFrame = toLocalDOMWindow(targetWindow)->frame();
-    if (!targetFrame)
-        return false;
-
-    // Notify the loader's client if the initial document has been accessed.
-    if (targetFrame->loader().stateMachine()->isDisplayingInitialEmptyDocument())
-        targetFrame->loader().didAccessInitialDocument();

[haraken, 2016/08/13 02:29:36]

You're saying that this CL will call didAccessInitialDocument more often, but
that's not necessarily the case here. Before this CL, didAccessInitialDocument
was called for an access where shouldAllowAccessTo returns false. After this CL,
didAccessInitialDocument is called only when shouldAllowAccessTo returns true.

The change looks good to me but just want to confirm that that is your
intention.

[Yuki, 2016/08/15 03:42:58]

You're right.  Not necessarily, but it's intentional.  If a window does not have
access to another window, there must be no chance to modify the initial document
of another window.  So, there is no need to call didAccessInitialDocument.

Having said that, it's also true that there are more call sites of
BindingSecurity::shouldAllowAccessTo() than the call sites of securityCheck().

-
+    const DOMWindow* targetWindow = V8Window::toImpl(window);
     return BindingSecurity::shouldAllowAccessTo(isolate, toLocalDOMWindow(toDOMWindow(accessingContext)), targetWindow, DoNotReportSecurityError);
     {% else %}{# if interface_name == 'Window' #}
     {# Not 'Window' means it\'s Location. #}