Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Issue 2209293002: fix #26414, infer return types of local functions (Closed)

Created:
4 years, 4 months ago by Jennifer Messerly
Modified:
4 years, 4 months ago
Reviewers:
Leaf
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : update changelog #

Total comments: 5

Patch Set 3 : fix #

Patch Set 4 : mark failing ast inference #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -2 lines) Patch
M CHANGELOG.md View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/static_type_analyzer.dart View 3 chunks +13 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/strong_mode_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/src/summary/resynthesize_ast_test.dart View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer/test/src/task/strong/inferred_type_test.dart View 1 2 3 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Jennifer Messerly
This fixes https://github.com/dart-lang/sdk/issues/26414. We only infer return types, treating them similarly to how lambdas are ...
4 years, 4 months ago (2016-08-04 14:24:18 UTC) #2
Jennifer Messerly
https://codereview.chromium.org/2209293002/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart File pkg/analyzer/lib/src/generated/static_type_analyzer.dart (right): https://codereview.chromium.org/2209293002/diff/1/pkg/analyzer/lib/src/generated/static_type_analyzer.dart#newcode501 pkg/analyzer/lib/src/generated/static_type_analyzer.dart:501: void _inferLocalFunctionReturnType(FunctionExpression node) { note: intentionally didn't sort this ...
4 years, 4 months ago (2016-08-04 14:25:05 UTC) #3
Leaf
lgtm. This is another breaking change, we should make a changelog note. We should also ...
4 years, 4 months ago (2016-08-04 17:07:52 UTC) #4
Jennifer Messerly
On 2016/08/04 17:07:52, Leaf wrote: > lgtm. This is another breaking change, we should make ...
4 years, 4 months ago (2016-08-04 18:22:20 UTC) #5
Leaf
lgtm https://codereview.chromium.org/2209293002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2209293002/diff/20001/CHANGELOG.md#newcode10 CHANGELOG.md:10: * Strong mode breaking change - infer generic ...
4 years, 4 months ago (2016-08-04 21:43:58 UTC) #6
Jennifer Messerly
https://codereview.chromium.org/2209293002/diff/20001/CHANGELOG.md File CHANGELOG.md (right): https://codereview.chromium.org/2209293002/diff/20001/CHANGELOG.md#newcode10 CHANGELOG.md:10: * Strong mode breaking change - infer generic type ...
4 years, 4 months ago (2016-08-04 22:11:12 UTC) #7
Jennifer Messerly
4 years, 4 months ago (2016-08-05 14:25:18 UTC) #9
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
1bb6da793729826a960745243c31d04b67d9b0ef (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698