Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issue 2209273002: [elements] limit TypedElementsAccessor::IncludesValue to backing store length (Closed)

Created:
4 years, 4 months ago by caitp
Modified:
4 years, 4 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[elements] limit TypedElementsAccessor::IncludesValue to backing store length The contract is that the method is only invoked when there are no elements on the prototype, and this elements type forbids accessor elements. So it is safe to limit the search to the end of the backing store. BUG=chromium:634269, v8:5162 R=cbruni@chromium.org, mstarzinger@chromium.org Committed: https://crrev.com/0d7f7dc3ee2181da5f6930925275e8e9342d0897 Cr-Commit-Position: refs/heads/master@{#38344}

Patch Set 1 #

Patch Set 2 : Fix signed/unsigned comparison warnings #

Patch Set 3 : Try again to make windows happy #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M src/elements.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
A + test/mjsunit/es7/regress/regress-634269.js View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 19 (14 generated)
caitp
PTAL
4 years, 4 months ago (2016-08-04 14:04:28 UTC) #3
Camillo Bruni
lgtm
4 years, 4 months ago (2016-08-04 15:35:05 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2209273002/40001
4 years, 4 months ago (2016-08-04 15:51:06 UTC) #16
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 4 months ago (2016-08-04 15:53:18 UTC) #17
commit-bot: I haz the power
4 years, 4 months ago (2016-08-04 15:55:03 UTC) #19
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d7f7dc3ee2181da5f6930925275e8e9342d0897
Cr-Commit-Position: refs/heads/master@{#38344}

Powered by Google App Engine
This is Rietveld 408576698