Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Side by Side Diff: third_party/WebKit/Source/bindings/modules/v8/custom/V8IDBObserverCustom.cpp

Issue 2209203002: binding: Always throws an exception in the current realm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed review comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "bindings/modules/v8/V8IDBObserver.h" 5 #include "bindings/modules/v8/V8IDBObserver.h"
6 6
7 #include "bindings/core/v8/ExceptionMessages.h" 7 #include "bindings/core/v8/ExceptionMessages.h"
8 #include "bindings/core/v8/ExceptionState.h" 8 #include "bindings/core/v8/ExceptionState.h"
9 #include "bindings/core/v8/V8Binding.h" 9 #include "bindings/core/v8/V8Binding.h"
10 #include "bindings/core/v8/V8DOMWrapper.h" 10 #include "bindings/core/v8/V8DOMWrapper.h"
11 #include "bindings/modules/v8/V8IDBObserverCallback.h" 11 #include "bindings/modules/v8/V8IDBObserverCallback.h"
12 #include "bindings/modules/v8/V8IDBObserverInit.h" 12 #include "bindings/modules/v8/V8IDBObserverInit.h"
13 13
14 namespace blink { 14 namespace blink {
15 15
16 void V8IDBObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info) 16 void V8IDBObserver::constructorCustom(const v8::FunctionCallbackInfo<v8::Value>& info)
17 { 17 {
18 if (UNLIKELY(info.Length() < 1)) { 18 if (UNLIKELY(info.Length() < 1)) {
19 V8ThrowException::throwException(createMinimumArityTypeErrorForConstruct or(info.GetIsolate(), "IDBObserver", 1, info.Length()), info.GetIsolate()); 19 V8ThrowException::throwException(info.GetIsolate(), createMinimumArityTy peErrorForConstructor(info.GetIsolate(), "IDBObserver", 1, info.Length()));
20 return; 20 return;
21 } 21 }
22 22
23 v8::Local<v8::Object> wrapper = info.Holder(); 23 v8::Local<v8::Object> wrapper = info.Holder();
24 24
25 if (!info[0]->IsFunction()) { 25 if (!info[0]->IsFunction()) {
26 V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::f ailedToConstruct("IDBObserver", "The callback provided as parameter 1 is not a f unction.")); 26 V8ThrowException::throwTypeError(info.GetIsolate(), ExceptionMessages::f ailedToConstruct("IDBObserver", "The callback provided as parameter 1 is not a f unction."));
27 return; 27 return;
28 } 28 }
29 29
(...skipping 10 matching lines...) Expand all
40 40
41 IDBObserverCallback* callback = new V8IDBObserverCallback(v8::Local<v8::Func tion>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate())); 41 IDBObserverCallback* callback = new V8IDBObserverCallback(v8::Local<v8::Func tion>::Cast(info[0]), wrapper, ScriptState::current(info.GetIsolate()));
42 IDBObserver* observer = IDBObserver::create(*callback, idbObserverInit); 42 IDBObserver* observer = IDBObserver::create(*callback, idbObserverInit);
43 if (exceptionState.throwIfNeeded()) 43 if (exceptionState.throwIfNeeded())
44 return; 44 return;
45 DCHECK(observer); 45 DCHECK(observer);
46 v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsol ate(), observer, &wrapperTypeInfo, wrapper)); 46 v8SetReturnValue(info, V8DOMWrapper::associateObjectWithWrapper(info.GetIsol ate(), observer, &wrapperTypeInfo, wrapper));
47 } 47 }
48 48
49 } // namespace blink 49 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698