Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: components/arc/arc_service_manager.cc

Issue 2209173002: Migrate ArcUserDataService into ArcAuthService. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added more comments. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/arc/arc_service_manager.cc
diff --git a/components/arc/arc_service_manager.cc b/components/arc/arc_service_manager.cc
index 21b8f37cf06f0d0a3faf2346b632844d92ca8598..76edff252894157f0f7222cd3afc863c5c5b1a6a 100644
--- a/components/arc/arc_service_manager.cc
+++ b/components/arc/arc_service_manager.cc
@@ -99,10 +99,6 @@ void ArcServiceManager::OnPrimaryUserProfilePrepared(
const AccountId& account_id,
std::unique_ptr<BooleanPrefMember> arc_enabled_pref) {
DCHECK(thread_checker_.CalledOnValidThread());
-
- arc_user_data_service_.reset(new ArcUserDataService(arc_bridge_service(),
Luis Héctor Chávez 2016/08/09 16:40:02 Wouldn't this break https://cs.chromium.org/chromi
hidehiko 2016/08/10 05:41:19 In new code, it doesn't use ArcUserDataService, so
Luis Héctor Chávez 2016/08/10 06:25:48 can you remove the getter? it will now be useless
hidehiko 2016/08/10 17:26:06 Ok. Done. Father clean up will be done in a follow
- std::move(arc_enabled_pref), account_id));
-
AddService(base::WrapUnique(
new ArcNotificationManager(arc_bridge_service(), account_id)));
}

Powered by Google App Engine
This is Rietveld 408576698