Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 220913003: Make supervised user ChromeOS import aware of new password schema. (Closed)

Created:
6 years, 8 months ago by Denis Kuznetsov (DE-MUC)
Modified:
6 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Make supervised user ChromeOS import aware of new password schema. R=nkostylev@chromium.org TBR=bauerb@chromium.org BUG=282464 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261482

Patch Set 1 #

Total comments: 3

Messages

Total messages: 8 (0 generated)
Nikita (slow)
lgtm https://codereview.chromium.org/220913003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc File chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc (right): https://codereview.chromium.org/220913003/diff/1/chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc#newcode267 chrome/browser/chromeos/login/managed/locally_managed_user_creation_screen.cc:267: bool password_right_here = value && value->GetAsDictionary(&password_data) && nit: ...
6 years, 8 months ago (2014-04-03 09:13:08 UTC) #1
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 8 months ago (2014-04-03 15:40:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/220913003/1
6 years, 8 months ago (2014-04-03 15:41:28 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 15:49:32 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_compile_dbg
6 years, 8 months ago (2014-04-03 15:49:32 UTC) #5
Denis Kuznetsov (DE-MUC)
The CQ bit was checked by antrim@chromium.org
6 years, 8 months ago (2014-04-03 15:52:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/antrim@chromium.org/220913003/1
6 years, 8 months ago (2014-04-03 15:53:14 UTC) #7
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 18:23:28 UTC) #8
Message was sent while issue was closed.
Change committed as 261482

Powered by Google App Engine
This is Rietveld 408576698